diff options
author | Dan Goodliffe <dan@randomdan.homeip.net> | 2019-04-01 19:21:30 +0100 |
---|---|---|
committer | Dan Goodliffe <dan@randomdan.homeip.net> | 2019-04-01 19:21:30 +0100 |
commit | e9dd0b8bb6a411698d850af0a50d9aeaa0187e95 (patch) | |
tree | 99f514118e5448869d8d31fdc582c090f6d28037 /netfs/daemon | |
parent | Enable hicpp tidy checks (diff) | |
download | netfs-e9dd0b8bb6a411698d850af0a50d9aeaa0187e95.tar.bz2 netfs-e9dd0b8bb6a411698d850af0a50d9aeaa0187e95.tar.xz netfs-e9dd0b8bb6a411698d850af0a50d9aeaa0187e95.zip |
Enable performance tidy checks
Diffstat (limited to 'netfs/daemon')
-rw-r--r-- | netfs/daemon/daemon.cpp | 1 | ||||
-rw-r--r-- | netfs/daemon/daemonService.cpp | 2 | ||||
-rw-r--r-- | netfs/daemon/daemonVolume.cpp | 2 |
3 files changed, 3 insertions, 2 deletions
diff --git a/netfs/daemon/daemon.cpp b/netfs/daemon/daemon.cpp index 2962ede..a773716 100644 --- a/netfs/daemon/daemon.cpp +++ b/netfs/daemon/daemon.cpp @@ -65,6 +65,7 @@ NetFSDaemon::stop() extern "C" { DLL_PUBLIC IceBox::Service * + // NOLINTNEXTLINE(performance-unnecessary-value-param) createNetFSDaemon(Ice::CommunicatorPtr) { return new NetFSDaemon(); diff --git a/netfs/daemon/daemonService.cpp b/netfs/daemon/daemonService.cpp index 30dac0a..fd5a0fd 100644 --- a/netfs/daemon/daemonService.cpp +++ b/netfs/daemon/daemonService.cpp @@ -11,7 +11,7 @@ ServiceServer::ServiceServer(NetFS::Daemon::ConfigurationPtr c) : NetFS::VolumePrxPtr ServiceServer::connect(const std::string share, const std::string authtoken, const Ice::Current & ice) { - auto ex = AdHoc::safeMapLookup<NetFS::ExportNotFound>(config->Exports, share); + const auto & ex = AdHoc::safeMapLookup<NetFS::ExportNotFound>(config->Exports, share); if (!ex->AuthToken.empty() && ex->AuthToken != authtoken) { throw NetFS::AuthError(); } diff --git a/netfs/daemon/daemonVolume.cpp b/netfs/daemon/daemonVolume.cpp index 074580c..dc16011 100644 --- a/netfs/daemon/daemonVolume.cpp +++ b/netfs/daemon/daemonVolume.cpp @@ -303,7 +303,7 @@ std::filesystem::path normalizedAppend(std::filesystem::path out, const std::filesystem::path && in) { unsigned int depth = 0; - for(auto e : in) { + for(const auto & e : in) { if (e.empty() || e == "." || e == "/") { continue; } |