diff options
| author | Benoit Foucher <benoit@zeroc.com> | 2018-05-03 16:40:47 +0200 |
|---|---|---|
| committer | Benoit Foucher <benoit@zeroc.com> | 2018-05-03 16:40:59 +0200 |
| commit | 75d923080037abc369a068e03c3f9076a83d3879 (patch) | |
| tree | faf99fc07c3b14d63c2ffaedd6ca899ec7255bac /php/src/php7/Properties.cpp | |
| parent | Remove useless lock in .NET TraceLoggerI (diff) | |
| download | ice-75d923080037abc369a068e03c3f9076a83d3879.tar.bz2 ice-75d923080037abc369a068e03c3f9076a83d3879.tar.xz ice-75d923080037abc369a068e03c3f9076a83d3879.zip | |
Fixed issue where parsing of 64-bits values would be incorrect on Windows, fixes #79
Diffstat (limited to 'php/src/php7/Properties.cpp')
| -rw-r--r-- | php/src/php7/Properties.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/php/src/php7/Properties.cpp b/php/src/php7/Properties.cpp index 16abe91eea7..87d040f7c65 100644 --- a/php/src/php7/Properties.cpp +++ b/php/src/php7/Properties.cpp @@ -162,7 +162,7 @@ ZEND_METHOD(Ice_Properties, getPropertyAsIntWithDefault) { char* name; size_t nameLen; - long def; + zend_long def; if(zend_parse_parameters(ZEND_NUM_ARGS(), const_cast<char*>("sl"), &name, &nameLen, &def) == FAILURE) { @@ -175,8 +175,9 @@ ZEND_METHOD(Ice_Properties, getPropertyAsIntWithDefault) string propName(name, nameLen); try { - Ice::Int val = _this->getPropertyAsIntWithDefault(propName, def); - RETURN_LONG(static_cast<long>(val)); + // TODO: Range check + Ice::Int val = _this->getPropertyAsIntWithDefault(propName, static_cast<Ice::Int>(def)); + RETURN_LONG(val); } catch(const IceUtil::Exception& ex) { |