Fixed Ice/timeout test to ensure the client doesn't hang in case of test failure

1 files changed, 19 insertions, 4 deletions

diff --git a/java/test/src/main/java/test/Ice/timeout/AllTests.java b/java/test/src/main/java/test/Ice/timeout/AllTests.java
index 8b5e2fbe11f..80f99bc89c8 100644
--- a/java/test/src/main/java/test/Ice/timeout/AllTests.java
+++ b/java/test/src/main/java/test/Ice/timeout/AllTests.java
@@ -73,6 +73,25 @@ public class AllTests
 
     public static void allTests(test.TestHelper helper)
     {
+        ControllerPrx controller = ControllerPrx.checkedCast(
+           helper.communicator().stringToProxy("controller:" + helper.getTestEndpoint(1)));
+        test(controller != null);
+
+        try
+        {
+            allTestsWithController(helper, controller);
+        }
+        catch(Exception ex)
+        {
+            // Ensure the adapter is not in the holding state when an unexpected exception occurs to prevent the test
+            // from hanging on exit in case a connection which disables timeouts is still opened.
+            controller.resumeAdapter();
+            throw ex;
+        }
+    }
+
+    public static void allTestsWithController(test.TestHelper helper, ControllerPrx controller)
+    {
         com.zeroc.Ice.Communicator communicator = helper.communicator();
         PrintWriter out = helper.getWriter();
 
@@ -90,10 +109,6 @@ public class AllTests
         TimeoutPrx timeout = TimeoutPrx.checkedCast(obj);
         test(timeout != null);
 
-        ControllerPrx controller = ControllerPrx.checkedCast(
-           communicator.stringToProxy("controller:" + helper.getTestEndpoint(1)));
-        test(controller != null);
-
         out.print("testing connect timeout... ");
         out.flush();
         {