summaryrefslogtreecommitdiff
path: root/java/src
diff options
context:
space:
mode:
authorDwayne Boone <dwayne@zeroc.com>2007-06-14 10:44:41 -0230
committerDwayne Boone <dwayne@zeroc.com>2007-06-14 10:44:41 -0230
commit9384d90d200a46c26a22135d4f4e39be78d04ab0 (patch)
tree301242e7633043ec9225e2732a81037f438da9c4 /java/src
parentFixed bug 2254 (diff)
downloadice-9384d90d200a46c26a22135d4f4e39be78d04ab0.tar.bz2
ice-9384d90d200a46c26a22135d4f4e39be78d04ab0.tar.xz
ice-9384d90d200a46c26a22135d4f4e39be78d04ab0.zip
No longer necessary to expand enpoints in proxies, use same mechanism as for multihomed hosts.
Added some missing .gitignore files.
Diffstat (limited to 'java/src')
-rw-r--r--java/src/Ice/ObjectAdapterI.java2
-rw-r--r--java/src/IceInternal/EndpointI.java4
-rw-r--r--java/src/IceInternal/ReferenceFactory.java3
-rw-r--r--java/src/IceInternal/TcpConnector.java10
-rw-r--r--java/src/IceInternal/TcpEndpointI.java6
-rw-r--r--java/src/IceInternal/UdpConnector.java10
-rw-r--r--java/src/IceInternal/UdpEndpointI.java6
-rw-r--r--java/src/IceInternal/UnknownEndpointI.java4
8 files changed, 30 insertions, 15 deletions
diff --git a/java/src/Ice/ObjectAdapterI.java b/java/src/Ice/ObjectAdapterI.java
index 03c2bce9d87..6275105e550 100644
--- a/java/src/Ice/ObjectAdapterI.java
+++ b/java/src/Ice/ObjectAdapterI.java
@@ -1186,7 +1186,7 @@ public final class ObjectAdapterI implements ObjectAdapter
while(p.hasNext())
{
IceInternal.EndpointI endp = (IceInternal.EndpointI)p.next();
- java.util.ArrayList endps = endp.expand(false);
+ java.util.ArrayList endps = endp.expand();
expandedEndpoints.addAll(endps);
}
return expandedEndpoints;
diff --git a/java/src/IceInternal/EndpointI.java b/java/src/IceInternal/EndpointI.java
index c5857e7dff7..1f398864448 100644
--- a/java/src/IceInternal/EndpointI.java
+++ b/java/src/IceInternal/EndpointI.java
@@ -112,9 +112,9 @@ abstract public class EndpointI implements Ice.Endpoint, java.lang.Comparable
//
// Expand endpoint out in to separate endpoints for each local
- // host if endpoint was configured with no host set.
+ // host if listening on INADDR_NAY.
//
- public abstract java.util.ArrayList expand(boolean includeLoopback);
+ public abstract java.util.ArrayList expand();
//
// Check whether the endpoint is equivalent to a specific Connector.
diff --git a/java/src/IceInternal/ReferenceFactory.java b/java/src/IceInternal/ReferenceFactory.java
index f235e382683..d767996d872 100644
--- a/java/src/IceInternal/ReferenceFactory.java
+++ b/java/src/IceInternal/ReferenceFactory.java
@@ -428,8 +428,7 @@ public final class ReferenceFactory
EndpointI endp = _instance.endpointFactoryManager().create(es, false);
if(endp != null)
{
- java.util.ArrayList endps = endp.expand(true);
- endpoints.addAll(endps);
+ endpoints.add(endp);
}
else
{
diff --git a/java/src/IceInternal/TcpConnector.java b/java/src/IceInternal/TcpConnector.java
index 71a20e4f37a..2635d9ad881 100644
--- a/java/src/IceInternal/TcpConnector.java
+++ b/java/src/IceInternal/TcpConnector.java
@@ -57,7 +57,15 @@ final class TcpConnector implements Connector, java.lang.Comparable
public final boolean
equivalent(String host, int port)
{
- java.net.InetSocketAddress addr = Network.getAddress(host, port);
+ java.net.InetSocketAddress addr;
+ try
+ {
+ addr = Network.getAddress(host, port);
+ }
+ catch(Ice.DNSException ex)
+ {
+ return false;
+ }
return addr.equals(_addr);
}
diff --git a/java/src/IceInternal/TcpEndpointI.java b/java/src/IceInternal/TcpEndpointI.java
index bc7a3b46a79..941b1ee0cc3 100644
--- a/java/src/IceInternal/TcpEndpointI.java
+++ b/java/src/IceInternal/TcpEndpointI.java
@@ -362,10 +362,10 @@ final class TcpEndpointI extends EndpointI
//
// Expand endpoint out in to separate endpoints for each local
- // host if endpoint was configured with no host set.
+ // host if listening on INADDR_ANY.
//
public java.util.ArrayList
- expand(boolean includeLoopback)
+ expand()
{
java.util.ArrayList endps = new java.util.ArrayList();
if(_host.equals("0.0.0.0"))
@@ -375,7 +375,7 @@ final class TcpEndpointI extends EndpointI
while(iter.hasNext())
{
String host = (String)iter.next();
- if(includeLoopback || hosts.size() == 1 || !host.equals("127.0.0.1"))
+ if(hosts.size() == 1 || !host.equals("127.0.0.1"))
{
endps.add(new TcpEndpointI(_instance, host, _port, _timeout, _connectionId, _compress));
}
diff --git a/java/src/IceInternal/UdpConnector.java b/java/src/IceInternal/UdpConnector.java
index 790d76dd94e..e3c49b6955b 100644
--- a/java/src/IceInternal/UdpConnector.java
+++ b/java/src/IceInternal/UdpConnector.java
@@ -40,7 +40,15 @@ final class UdpConnector implements Connector, java.lang.Comparable
final public boolean
equivalent(String host, int port)
{
- java.net.InetSocketAddress addr = Network.getAddress(host, port);
+ java.net.InetSocketAddress addr;
+ try
+ {
+ addr = Network.getAddress(host, port);
+ }
+ catch(Ice.DNSException ex)
+ {
+ return false;
+ }
return addr.equals(_addr);
}
diff --git a/java/src/IceInternal/UdpEndpointI.java b/java/src/IceInternal/UdpEndpointI.java
index 976824b93d7..fc00be54842 100644
--- a/java/src/IceInternal/UdpEndpointI.java
+++ b/java/src/IceInternal/UdpEndpointI.java
@@ -528,10 +528,10 @@ final class UdpEndpointI extends EndpointI
//
// Expand endpoint out in to separate endpoints for each local
- // host if endpoint was configured with no host set.
+ // host if listening on INADDR_ANY.
//
public java.util.ArrayList
- expand(boolean includeLoopback)
+ expand()
{
java.util.ArrayList endps = new java.util.ArrayList();
if(_host.equals("0.0.0.0"))
@@ -541,7 +541,7 @@ final class UdpEndpointI extends EndpointI
while(iter.hasNext())
{
String host = (String)iter.next();
- if(includeLoopback || hosts.size() == 1 || !host.equals("127.0.0.1"))
+ if(hosts.size() == 1 || !host.equals("127.0.0.1"))
{
endps.add(new UdpEndpointI(_instance, host, _port, _mcastInterface, _mcastTtl, _connect,
_connectionId, _compress));
diff --git a/java/src/IceInternal/UnknownEndpointI.java b/java/src/IceInternal/UnknownEndpointI.java
index 75bffdd3163..226fe8f4bd0 100644
--- a/java/src/IceInternal/UnknownEndpointI.java
+++ b/java/src/IceInternal/UnknownEndpointI.java
@@ -260,10 +260,10 @@ final class UnknownEndpointI extends EndpointI
//
// Expand endpoint out in to separate endpoints for each local
- // host if endpoint was configured with no host set.
+ // host if listening on INADDR_ANY.
//
public java.util.ArrayList
- expand(boolean includeLoopback)
+ expand()
{
java.util.ArrayList endps = new java.util.ArrayList();
endps.add(this);