Fixed performance issues reported by FindBugs. Made corresponding

changes for C# where applicable.

1 files changed, 11 insertions, 6 deletions

diff --git a/java/src/IceInternal/ReferenceFactory.java b/java/src/IceInternal/ReferenceFactory.java
index 4eaebed5bfc..d329b6249a0 100644
--- a/java/src/IceInternal/ReferenceFactory.java
+++ b/java/src/IceInternal/ReferenceFactory.java
@@ -418,12 +418,14 @@ public final class ReferenceFactory
             else if(unknownEndpoints.size() != 0 &&
                    _instance.initializationData().properties.getPropertyAsIntWithDefault("Ice.Warn.Endpoints", 1) > 0)
             {
-                String msg = "Proxy contains unknown endpoints:";
+                StringBuffer msg = new StringBuffer("Proxy contains unknown endpoints:");
                 for(String e : unknownEndpoints)
                 {
-                    msg += " `" + e + "'";
+		    msg.append(" `");
+		    msg.append(e);
+		    msg.append("'");
                 }
-                _instance.initializationData().logger.warning(msg);
+                _instance.initializationData().logger.warning(msg.toString());
             }
 
             EndpointI[] endp = new EndpointI[endpoints.size()];
@@ -687,12 +689,15 @@ public final class ReferenceFactory
 
         if(unknownProps.size() != 0)
         {
-            String message = "found unknown properties for proxy '" + prefix + "':";
+            StringBuffer message = new StringBuffer("found unknown properties for proxy '");
+	    message.append(prefix);
+	    message.append("':");
             for(String s : unknownProps)
             {
-                message += "\n    " + s;
+		message.append("\n    ");
+		message.append(s);
             }
-            _instance.initializationData().logger.warning(message);
+            _instance.initializationData().logger.warning(message.toString());
         }
     }