summaryrefslogtreecommitdiff
path: root/java/src/IceInternal/Outgoing.java
diff options
context:
space:
mode:
authorMatthew Newhook <matthew@zeroc.com>2014-08-07 14:36:07 -0230
committerMatthew Newhook <matthew@zeroc.com>2014-08-07 14:36:07 -0230
commitb36ae21c88735cbd2c39c5ccde2572a8fcc4e928 (patch)
treedfd5eee6e7d61a9c6efcbaabe916639009aaa9af /java/src/IceInternal/Outgoing.java
parentAdd @Override where possible, and remove trailing white space. (diff)
downloadice-b36ae21c88735cbd2c39c5ccde2572a8fcc4e928.tar.bz2
ice-b36ae21c88735cbd2c39c5ccde2572a8fcc4e928.tar.xz
ice-b36ae21c88735cbd2c39c5ccde2572a8fcc4e928.zip
ICE-1593 Handling thread interrupts in Java
- Added Ice.BackgroundIO property to perform all IO in a non-user thread. This makes Ice for Java interrupt safe. This is implemented by the QueueRequestHanbler. - EndpointHostResolver now uses an executor instead of a thread. - Added java/demo/Ice/interrupt and java/test/Ice/interrupt. - Made several changes that must be ported to C++ & C#. - InvocationTimeout exceptions can hang forever. - Connection establishment is always asynchronous. - RequestHandler.requestTimeout and asyncRequestTimeout have been renamed to requestCancel and asyncRequestCancel.
Diffstat (limited to 'java/src/IceInternal/Outgoing.java')
-rw-r--r--java/src/IceInternal/Outgoing.java76
1 files changed, 59 insertions, 17 deletions
diff --git a/java/src/IceInternal/Outgoing.java b/java/src/IceInternal/Outgoing.java
index c4f79392e36..333671c8b86 100644
--- a/java/src/IceInternal/Outgoing.java
+++ b/java/src/IceInternal/Outgoing.java
@@ -97,11 +97,43 @@ public final class Outgoing implements OutgoingMessageCallback
_exception = null;
_sent = false;
- _handler = _proxy.__getRequestHandler(false);
-
- if(_handler.sendRequest(this)) // Request sent and no response expected, we're done.
+ _handler = _proxy.__getRequestHandler();
+ try
+ {
+ if(_handler.sendRequest(this)) // Request sent and no response expected, we're done.
+ {
+ return true;
+ }
+ }
+ catch(Ice.OperationInterruptedException ex)
{
- return true;
+ if(_handler.requestCanceled(this, new Ice.OperationInterruptedException()))
+ {
+ //
+ // Wait for the exception to propagate. It's possible the request handler ignores
+ // the timeout if there was a failure shortly before requestTimedOut got called.
+ // In this case, the exception should be set on the Outgoing.
+ //
+ synchronized(this)
+ {
+ boolean interrupted = false;
+ while(_exception == null)
+ {
+ try
+ {
+ wait();
+ }
+ catch(InterruptedException ex2)
+ {
+ interrupted = true;
+ }
+ }
+ if(interrupted)
+ {
+ Thread.currentThread().interrupt();
+ }
+ }
+ }
}
boolean timedOut = false;
@@ -124,6 +156,7 @@ public final class Outgoing implements OutgoingMessageCallback
}
catch(InterruptedException ex)
{
+ throw new Ice.OperationInterruptedException();
}
if((_state == StateInProgress || !_sent) && _state != StateFailed)
{
@@ -142,6 +175,7 @@ public final class Outgoing implements OutgoingMessageCallback
}
catch(InterruptedException ex)
{
+ throw new Ice.OperationInterruptedException();
}
}
}
@@ -149,23 +183,30 @@ public final class Outgoing implements OutgoingMessageCallback
if(timedOut)
{
- _handler.requestTimedOut(this);
-
- //
- // Wait for the exception to propagate. It's possible the request handler ignores
- // the timeout if there was a failure shortly before requestTimedOut got called.
- // In this case, the exception should be set on the Outgoing.
- //
- synchronized(this)
+ if(_handler.requestCanceled(this, new Ice.InvocationTimeoutException()))
{
- while(_exception == null)
+ //
+ // Wait for the exception to propagate. It's possible the request handler ignores
+ // the timeout if there was a failure shortly before requestTimedOut got called.
+ // In this case, the exception should be set on the Outgoing.
+ //
+ synchronized(this)
{
- try
+ boolean interrupted = false;
+ while(_exception == null)
{
- wait();
+ try
+ {
+ wait();
+ }
+ catch(InterruptedException ex)
+ {
+ interrupted = true;
+ }
}
- catch(InterruptedException ex)
+ if(interrupted)
{
+ Thread.currentThread().interrupt();
}
}
}
@@ -203,6 +244,7 @@ public final class Outgoing implements OutgoingMessageCallback
}
catch(InterruptedException exi)
{
+ throw new Ice.OperationInterruptedException();
}
}
}
@@ -584,7 +626,7 @@ public final class Outgoing implements OutgoingMessageCallback
{
try
{
- _handler = _proxy.__getRequestHandler(true);
+ _handler = _proxy.__getRequestHandler();
_handler.prepareBatchRequest(_os);
break;
}