diff options
author | Jose <jose@zeroc.com> | 2018-05-03 17:16:38 +0200 |
---|---|---|
committer | Jose <jose@zeroc.com> | 2018-05-03 17:16:38 +0200 |
commit | c6ed85aaf0480cb1fb63eecf43b5077209125f6c (patch) | |
tree | 2d9195637e20b301bd051203be34db10092fc232 /csharp/src | |
parent | Missing dependency for Glacier2 tests (diff) | |
download | ice-c6ed85aaf0480cb1fb63eecf43b5077209125f6c.tar.bz2 ice-c6ed85aaf0480cb1fb63eecf43b5077209125f6c.tar.xz ice-c6ed85aaf0480cb1fb63eecf43b5077209125f6c.zip |
Remove useless lock in .NET TraceLoggerI
Diffstat (limited to 'csharp/src')
-rw-r--r-- | csharp/src/Ice/LoggerI.cs | 32 |
1 files changed, 13 insertions, 19 deletions
diff --git a/csharp/src/Ice/LoggerI.cs b/csharp/src/Ice/LoggerI.cs index 9b8c60aa76c..8d093e6489c 100644 --- a/csharp/src/Ice/LoggerI.cs +++ b/csharp/src/Ice/LoggerI.cs @@ -88,8 +88,8 @@ namespace Ice protected abstract void write(string message); - internal string _prefix = ""; - internal string _formattedPrefix = ""; + internal readonly string _prefix; + internal readonly string _formattedPrefix; internal string _date = null; internal string _time = null; @@ -147,10 +147,12 @@ namespace Ice public class ConsoleListener : TraceListener { - public ConsoleListener() + public override bool IsThreadSafe { - _date = "d"; - _time = "HH:mm:ss:fff"; + get + { + return true; + } } public override void TraceEvent(TraceEventCache cache, string source, TraceEventType type, @@ -188,8 +190,8 @@ namespace Ice System.Console.Error.WriteLine(message); } - internal string _date = null; - internal string _time = null; + internal const string _date = "d"; + internal const string _time = "HH:mm:ss:fff"; } public sealed class TraceLoggerI : LoggerI @@ -206,22 +208,14 @@ namespace Ice public override void trace(string category, string message) { - string s = format(category, message); - lock(_globalMutex) - { - Trace.TraceInformation(s); - Trace.Flush(); - } + Trace.TraceInformation(format(category, message)); + Trace.Flush(); } public override void warning(string message) { - string s = format("warning", message); - lock(_globalMutex) - { - Trace.TraceWarning(s); - Trace.Flush(); - } + Trace.TraceWarning(format("warning", message)); + Trace.Flush(); } public override void error(string message) |