CSharp cleanup and fixes:

- Add EditorBrowsable(EditorBrowsableState.Never) to
  hidde internal public methods from Intellisense,
  see ICE-7448.
- Remove Base64 and replace it with .NET System.Convert
  see ICE-7477
- Remove SysLogger as that was only used by Mono
- Simplify ThreadPriority setting
- Remove using statements that are not required
- Normalize string, char, object spell, preferred over
  String, Char, Object
- Shorthen qualifier names avoiding redundant scopes.

1 files changed, 6 insertions, 7 deletions

diff --git a/csharp/src/Ice/TraceUtil.cs b/csharp/src/Ice/TraceUtil.cs
index 54e2783a187..37d883f7ef3 100644
--- a/csharp/src/Ice/TraceUtil.cs
+++ b/csharp/src/Ice/TraceUtil.cs
@@ -91,7 +91,7 @@ namespace IceInternal
 
         internal static void traceSlicing(string kind, string typeId, string slicingCat, Ice.Logger logger)
         {
-            lock(typeof(IceInternal.TraceUtil))
+            lock(typeof(TraceUtil))
             {
                 if(slicingIds.Add(typeId))
                 {
@@ -126,7 +126,7 @@ namespace IceInternal
                 {
                     if(j < data.Length)
                     {
-                        int n = (int)data[j];
+                        int n = data[j];
                         if(n < 0)
                         {
                             n += 256;
@@ -157,7 +157,7 @@ namespace IceInternal
                 for(int j = i; j < data.Length && j - i < inc; j++)
                 {
                     // TODO: this needs fixing
-                    if(data[j] >= (byte)32 && data[j] < (byte)127)
+                    if(data[j] >= 32 && data[j] < 127)
                     {
                         System.Console.Out.Write((char) data[j]);
                     }
@@ -175,7 +175,6 @@ namespace IceInternal
         {
             try
             {
-
                 Ice.ToStringMode toStringMode = Ice.ToStringMode.Unicode;
                 if(str.instance() != null)
                 {
@@ -422,19 +421,19 @@ namespace IceInternal
                 s.Write("\ncompression status = " + (int)compress + ' ');
                 switch(compress)
                 {
-                case (byte)0:
+                case 0:
                 {
                     s.Write("(not compressed; do not compress response, if any)");
                     break;
                 }
 
-                case (byte)1:
+                case 1:
                 {
                     s.Write("(not compressed; compress response, if any)");
                     break;
                 }
 
-                case (byte)2:
+                case 2:
                 {
                     s.Write("(compressed; compress response, if any)");
                     break;