diff options
author | Jose <jose@zeroc.com> | 2018-06-06 19:48:11 +0200 |
---|---|---|
committer | Jose <jose@zeroc.com> | 2018-06-06 19:48:57 +0200 |
commit | a93cb6bfcaa59ebd753cacd188514bdb87648bd8 (patch) | |
tree | 6bec028432912e691088475ac8a2d1af550b414a /cpp/test/ios/controller | |
parent | Fixed bug where binary distribution testing would fail to build the TestCommo... (diff) | |
download | ice-a93cb6bfcaa59ebd753cacd188514bdb87648bd8.tar.bz2 ice-a93cb6bfcaa59ebd753cacd188514bdb87648bd8.tar.xz ice-a93cb6bfcaa59ebd753cacd188514bdb87648bd8.zip |
iOS test controller fixes
Diffstat (limited to 'cpp/test/ios/controller')
3 files changed, 15 insertions, 10 deletions
diff --git a/cpp/test/ios/controller/Bundle/ControllerI.mm b/cpp/test/ios/controller/Bundle/ControllerI.mm index 7a3aca76931..01ce5e193de 100644 --- a/cpp/test/ios/controller/Bundle/ControllerI.mm +++ b/cpp/test/ios/controller/Bundle/ControllerI.mm @@ -31,9 +31,6 @@ namespace class ControllerHelperI : public Test::ControllerHelper, private IceUtil::Monitor<IceUtil::Mutex>, public IceUtil::Thread -#ifdef ICE_CPP11_MAPPING - , public enable_shared_from_this<ControllerHelperI> -#endif { public: @@ -67,7 +64,6 @@ namespace std::ostringstream _out; IceInternal::UniquePtr<Test::TestHelper> _helper; }; - ICE_DEFINE_PTR(ControllerHelperIPtr, ControllerHelperI); class ProcessI : public Process { @@ -133,6 +129,11 @@ _status(0) ControllerHelperI::~ControllerHelperI() { + if(_helper) + { + _helper.release(); + } + if(_handle) { CFBundleUnloadExecutable(_handle); @@ -311,7 +312,9 @@ ControllerHelperI::getOutput() const return _out.str(); } -ProcessI::ProcessI(id<ControllerView> controller, ControllerHelperI* helper) : _controller(controller), _helper(helper) +ProcessI::ProcessI(id<ControllerView> controller, ControllerHelperI* helper) : + _controller(controller), + _helper(helper) { } @@ -356,7 +359,7 @@ ProcessControllerI::start(const string& testSuite, const string& exe, const Stri std::string prefix = std::string("test/") + testSuite; replace(prefix.begin(), prefix.end(), '/', '_'); [_controller println:[NSString stringWithFormat:@"starting %s %s... ", testSuite.c_str(), exe.c_str()]]; - ControllerHelperIPtr helper = ICE_MAKE_SHARED(ControllerHelperI, _controller, prefix + '/' + exe + ".bundle", args); + IceUtil::Handle<ControllerHelperI> helper(new ControllerHelperI(_controller, prefix + '/' + exe + ".bundle", args)); // // Use a 768KB thread stack size for the objects test. This is necessary when running the diff --git a/cpp/test/ios/controller/C++ Test Controller.xcodeproj/project.pbxproj b/cpp/test/ios/controller/C++ Test Controller.xcodeproj/project.pbxproj index cf9f87c6abb..4bf73de21bf 100644 --- a/cpp/test/ios/controller/C++ Test Controller.xcodeproj/project.pbxproj +++ b/cpp/test/ios/controller/C++ Test Controller.xcodeproj/project.pbxproj @@ -41,6 +41,7 @@ 14E398391E01B30E00A89291 /* CFNetwork.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 14E398371E01B30500A89291 /* CFNetwork.framework */; }; 8267256920A9EF6E0089EA2D /* Security.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 8267256820A9EF6E0089EA2D /* Security.framework */; }; 8267256A20A9F0210089EA2D /* Security.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 8267256820A9EF6E0089EA2D /* Security.framework */; }; + 828491FE20C82DAB00B4B721 /* ControllerView.m in Sources */ = {isa = PBXBuildFile; fileRef = 82A1B91620C0081200B3535B /* ControllerView.m */; }; 82A1B91820C0081200B3535B /* ControllerView.m in Sources */ = {isa = PBXBuildFile; fileRef = 82A1B91620C0081200B3535B /* ControllerView.m */; }; /* End PBXBuildFile section */ @@ -477,6 +478,7 @@ isa = PBXSourcesBuildPhase; buildActionMask = 2147483647; files = ( + 828491FE20C82DAB00B4B721 /* ControllerView.m in Sources */, 148ABA441DFEEAEE00594F70 /* AppDelegate.m in Sources */, 148ABA451DFEEAEE00594F70 /* main.m in Sources */, ); diff --git a/cpp/test/ios/controller/Classes/Base.lproj/Main.storyboard b/cpp/test/ios/controller/Classes/Base.lproj/Main.storyboard index 7bd9da90e09..1e639d92518 100644 --- a/cpp/test/ios/controller/Classes/Base.lproj/Main.storyboard +++ b/cpp/test/ios/controller/Classes/Base.lproj/Main.storyboard @@ -1,18 +1,18 @@ <?xml version="1.0" encoding="UTF-8"?> -<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="11762" systemVersion="16B2555" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="BYZ-38-t0r"> +<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14113" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="BYZ-38-t0r"> <device id="retina4_7" orientation="portrait"> <adaptation id="fullscreen"/> </device> <dependencies> <deployment identifier="iOS"/> - <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="11757"/> + <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="14088"/> <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/> </dependencies> <scenes> <!--View Controller--> <scene sceneID="tne-QT-ifu"> <objects> - <viewController id="BYZ-38-t0r" customClass="ViewController" sceneMemberID="viewController"> + <viewController id="BYZ-38-t0r" customClass="ControllerView" sceneMemberID="viewController"> <layoutGuides> <viewControllerLayoutGuide type="top" id="y3c-jy-aDJ"/> <viewControllerLayoutGuide type="bottom" id="wfy-db-euE"/> @@ -21,7 +21,7 @@ <rect key="frame" x="0.0" y="0.0" width="375" height="667"/> <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/> <subviews> - <pickerView contentMode="scaleToFill" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="xR3-DO-y6j" userLabel="InterfaceIPv6"> + <pickerView contentMode="scaleToFill" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="xR3-DO-y6j" userLabel="InterfaceIPv4"> <rect key="frame" x="40" y="49" width="296" height="75"/> <autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMaxY="YES"/> <connections> |