summaryrefslogtreecommitdiff
path: root/cpp/src/IceUtil/UtilException.cpp
diff options
context:
space:
mode:
authorBernard Normier <bernard@zeroc.com>2017-07-07 15:18:42 -0400
committerBernard Normier <bernard@zeroc.com>2017-07-07 15:18:42 -0400
commit4035f073128761486e20957bafd6dd8436a21339 (patch)
tree51bc38fb5e74a4da2b84c15b15d44fee55bd2d29 /cpp/src/IceUtil/UtilException.cpp
parentFixed ICE-8237 - deadlock in ConnectRequestHandler (diff)
downloadice-4035f073128761486e20957bafd6dd8436a21339.tar.bz2
ice-4035f073128761486e20957bafd6dd8436a21339.tar.xz
ice-4035f073128761486e20957bafd6dd8436a21339.zip
Updated backtrace_pcinfo comment
Diffstat (limited to 'cpp/src/IceUtil/UtilException.cpp')
-rw-r--r--cpp/src/IceUtil/UtilException.cpp11
1 files changed, 5 insertions, 6 deletions
diff --git a/cpp/src/IceUtil/UtilException.cpp b/cpp/src/IceUtil/UtilException.cpp
index 030950c9dde..96379dded08 100644
--- a/cpp/src/IceUtil/UtilException.cpp
+++ b/cpp/src/IceUtil/UtilException.cpp
@@ -136,14 +136,13 @@ public:
{
globalMutex = new IceUtil::Mutex;
#ifdef ICE_LIBBACKTRACE
- // Leaked, as libbacktrace does not provide an API to free
- // this state
+ // Leaked, as libbacktrace does not provide an API to free this state.
+ //
bstate = backtrace_create_state(0, 1, ignoreErrorCallback, 0);
- // The first call to backtrace_pcinfo initializes bstate->fileline_fn, apparently
- // not in a thread-safe manner (at least with GCC 5.4.0 on Ubuntu Xenial).
- // See ICE-8036. So we make a "dummy" call to backtrace_pcinfo here for
- // this extra initialization.
+ // The first call to backtrace_pcinfo does not initialize bstate->fileline_fn
+ // in a thread-safe manner, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81098.
+ // So we make a "dummy" call to backtrace_pcinfo to initialize it here.
//
backtrace_pcinfo(bstate, 0, ignoreFrame, ignoreErrorCallback, 0);
#endif