summaryrefslogtreecommitdiff
path: root/cpp/src/IcePack/ActivatorI.cpp
diff options
context:
space:
mode:
authorBenoit Foucher <benoit@zeroc.com>2002-07-25 03:31:06 +0000
committerBenoit Foucher <benoit@zeroc.com>2002-07-25 03:31:06 +0000
commit7b2b43a71525019de911b5a42024d07da89a0320 (patch)
treefb303946b16d6f6ddd9d199edf7a6ba5af66f675 /cpp/src/IcePack/ActivatorI.cpp
parentcommenbts (diff)
downloadice-7b2b43a71525019de911b5a42024d07da89a0320.tar.bz2
ice-7b2b43a71525019de911b5a42024d07da89a0320.tar.xz
ice-7b2b43a71525019de911b5a42024d07da89a0320.zip
Added targets and application descriptors.
Diffstat (limited to 'cpp/src/IcePack/ActivatorI.cpp')
-rw-r--r--cpp/src/IcePack/ActivatorI.cpp15
1 files changed, 7 insertions, 8 deletions
diff --git a/cpp/src/IcePack/ActivatorI.cpp b/cpp/src/IcePack/ActivatorI.cpp
index f8e7a7f66b2..e5ac96187a4 100644
--- a/cpp/src/IcePack/ActivatorI.cpp
+++ b/cpp/src/IcePack/ActivatorI.cpp
@@ -153,16 +153,15 @@ IcePack::ActivatorI::activate(const ServerPrx& server, const ::Ice::Current&)
// pipe.
//
// TODO: This doesn't work well if the server doesn't control
- // when and how the output is flushed. This can result for
- // example in printing on character by line... The standard
- // Ice logger could be changed to flush the stream and not use
- // automatic flushing.
+ // when and how the output is flushed. For example, we could
+ // receive one character after the other over the pipe which
+ // is problematic since we don't know when to log message. For
+ // sure we don't want to log each character one after the
+ // other. We want to log the message. One solution would be to
+ // put the received information in a buffer and log it only
+ // when we receive a '\n'.
//
-// TODO: ML: Can you be more specific? Sending messages through a pipe
-// is one of the most basic unix mechanisms. I don't see how this
-// could not work.
-
// if(fds[1] != STDERR_FILENO)
// {
// if(dup2(fds[1], STDERR_FILENO) != STDERR_FILENO)