Fixed ICE-4882:

Better logging in C++, especially with services. On compilers with
stack-trace printing support, the stack trace of most exceptions is
now logged.

1 files changed, 3 insertions, 5 deletions

diff --git a/cpp/src/Glacier2Lib/SessionHelper.cpp b/cpp/src/Glacier2Lib/SessionHelper.cpp
index 3080fe5c47f..a97e6706cd1 100644
--- a/cpp/src/Glacier2Lib/SessionHelper.cpp
+++ b/cpp/src/Glacier2Lib/SessionHelper.cpp
@@ -438,17 +438,15 @@ SessionHelperI::destroyInternal(const Ice::DispatcherCallPtr& disconnected)
             // This can also occur.
             //
         }
-        catch(const Ice::Exception& ex)
+        catch(const std::exception& ex)
         {
             //
             // Not expected.
             //
-            ostringstream os;
-            os << "SessionHelper: unexpected exception when destroying the session:\n";
-            os << ex;
             if(communicator)
             {
-                communicator->getLogger()->warning(os.str());
+                Ice::Warning warn(communicator->getLogger());
+                warn << "SessionHelper: unexpected exception when destroying the session:\n" << ex;
             }
         }
     }