comments

1 files changed, 10 insertions, 3 deletions

diff --git a/cpp/demo/Ice/session/SessionI.h b/cpp/demo/Ice/session/SessionI.h
index 9dd23990d01..2d46ef27d3d 100755
--- a/cpp/demo/Ice/session/SessionI.h
+++ b/cpp/demo/Ice/session/SessionI.h
@@ -28,11 +28,11 @@ public:
     virtual void refresh(const Ice::Current&);
     virtual void destroy(const Ice::Current&);
 
-    // XXX Should be private, with SessionFactoryI being a friend.
+    // XXX Should be private, with SessionFactoryI being a friend. (Or Reaper being a friend, see the other comments.)
     // Return true if the session is destroyed, false otherwise.
     bool destroyed() const;
 
-    // XXX Should be private, with SessionFactoryI being a friend.
+    // XXX Should be private, with SessionFactoryI being a friend. (Or Reaper being a friend, see the other comments.)
     // XXX The name is wrong. It's not a callback, it's a call.
     // XXX Why have this function at all? Why not do whatever this function does directly in destroy()?
     // per-client allocated resources.
@@ -40,9 +40,16 @@ public:
 
 private:
 
-    const Ice::ObjectAdapterPtr _adapter;
+    const Ice::ObjectAdapterPtr _adapter; // XXX Get rid of this (you can after all the other XXX's have been fixed).
+
+    // XXX Get rid of this. Only the reaper has to know this. It can
+    // call a timestamp() function, compare the elapsed time with its
+    // _timeout value, and call destroy() and reap if timed out.
+
     const IceUtil::Time _timeout; // How long until the session times out.
     bool _destroy; // true if destroy() was called, false otherwise.
+
+    // XXX Rename to _timestamp;
     IceUtil::Time _refreshTime; // The last time the session was refreshed.
     
     int _nextId; // The id of the next hello object. This is used for tracing purposes.