summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenoit Foucher <benoit@zeroc.com>2017-01-05 15:54:59 +0100
committerBenoit Foucher <benoit@zeroc.com>2017-01-05 15:54:59 +0100
commitf99ac49edc9a6bff2d8e2d9747e43b632a084ed3 (patch)
treef25c276c982bef9b500a37bfa62df95bbb131144
parentMerge remote-tracking branch 'origin/3.6' (diff)
downloadice-f99ac49edc9a6bff2d8e2d9747e43b632a084ed3.tar.bz2
ice-f99ac49edc9a6bff2d8e2d9747e43b632a084ed3.tar.xz
ice-f99ac49edc9a6bff2d8e2d9747e43b632a084ed3.zip
Fixed macOS PHP testing bug when running against binary distribution
-rw-r--r--scripts/Util.py17
1 files changed, 5 insertions, 12 deletions
diff --git a/scripts/Util.py b/scripts/Util.py
index a316f24060a..25b9ea9c890 100644
--- a/scripts/Util.py
+++ b/scripts/Util.py
@@ -2737,18 +2737,11 @@ class PhpMapping(CppBasedClientMapping):
def getCommandLine(self, current, process, exe):
args = []
- if current.driver.getIceDir(self, current) == platform.getIceInstallDir(self, current):
- #
- # If installed in the platform system directory and on Linux, we rely
- # on ice.ini to find the extension. On OS X, we still need to setup
- # the properties.
- #
- if(isinstance(platform, Darwin)):
- args += ["-n"] # Do not load any php.ini files
- args += ["-d", "extension_dir=/usr/local/lib/php/extensions"]
- args += ["-d", "include_path=/usr/local/share/php"]
- args += ["-d", "extension=IcePHP.so"]
- else:
+ #
+ # If Ice is not installed in the system directory, specify its location with PHP
+ # configuration arguments.
+ #
+ if current.driver.getIceDir(self, current) != platform.getIceInstallDir(self, current):
useBinDist = current.driver.useIceBinDist(self)
if isinstance(platform, Windows):
extension = "php_ice_nts.dll" if "NTS" in run("php -v") else "php_ice.dll"