diff options
| author | Brent Eagles <brent@zeroc.com> | 2006-04-28 16:04:57 +0000 |
|---|---|---|
| committer | Brent Eagles <brent@zeroc.com> | 2006-04-28 16:04:57 +0000 |
| commit | df19bb86c00d3335e01bf5e01f6b256aa0077f86 (patch) | |
| tree | 49a077d6616e9037573a1833c0f0febe27ef860d | |
| parent | adding IceSSL.FindCert (diff) | |
| download | ice-df19bb86c00d3335e01bf5e01f6b256aa0077f86.tar.bz2 ice-df19bb86c00d3335e01bf5e01f6b256aa0077f86.tar.xz ice-df19bb86c00d3335e01bf5e01f6b256aa0077f86.zip | |
Adding warning comments about changing toString() behaviors that may break
features.
| -rw-r--r-- | cpp/src/Ice/TcpEndpointI.cpp | 7 | ||||
| -rw-r--r-- | cpp/src/Ice/UdpEndpointI.cpp | 7 | ||||
| -rw-r--r-- | cpp/src/IceSSL/EndpointI.cpp | 7 |
3 files changed, 21 insertions, 0 deletions
diff --git a/cpp/src/Ice/TcpEndpointI.cpp b/cpp/src/Ice/TcpEndpointI.cpp index fe1eca4ec99..726734bed07 100644 --- a/cpp/src/Ice/TcpEndpointI.cpp +++ b/cpp/src/Ice/TcpEndpointI.cpp @@ -183,6 +183,13 @@ IceInternal::TcpEndpointI::streamWrite(BasicStream* s) const string IceInternal::TcpEndpointI::toString() const { + // + // WARNING: Certain features, such as proxy validation in Glacier2, + // depend on the format of proxy strings. Changes to toString() and + // methods called to generate parts of the reference string could break + // these features. Please review for all features that depend on the + // format of proxyToString() before changing this and related code. + // ostringstream s; s << "tcp -h " << _host << " -p " << _port; if(_timeout != -1) diff --git a/cpp/src/Ice/UdpEndpointI.cpp b/cpp/src/Ice/UdpEndpointI.cpp index b4a4abd2e28..de5a26c424e 100644 --- a/cpp/src/Ice/UdpEndpointI.cpp +++ b/cpp/src/Ice/UdpEndpointI.cpp @@ -335,6 +335,13 @@ IceInternal::UdpEndpointI::streamWrite(BasicStream* s) const string IceInternal::UdpEndpointI::toString() const { + // + // WARNING: Certain features, such as proxy validation in Glacier2, + // depend on the format of proxy strings. Changes to toString() and + // methods called to generate parts of the reference string could break + // these features. Please review for all features that depend on the + // format of proxyToString() before changing this and related code. + // ostringstream s; s << "udp"; diff --git a/cpp/src/IceSSL/EndpointI.cpp b/cpp/src/IceSSL/EndpointI.cpp index 361ca90e3ae..3d80ad38f96 100644 --- a/cpp/src/IceSSL/EndpointI.cpp +++ b/cpp/src/IceSSL/EndpointI.cpp @@ -183,6 +183,13 @@ IceSSL::EndpointI::streamWrite(IceInternal::BasicStream* s) const string IceSSL::EndpointI::toString() const { + // + // WARNING: Certain features, such as proxy validation in Glacier2, + // depend on the format of proxy strings. Changes to toString() and + // methods called to generate parts of the reference string could break + // these features. Please review for all features that depend on the + // format of proxyToString() before changing this and related code. + // ostringstream s; s << "ssl -h " << _host << " -p " << _port; if(_timeout != -1) |