summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDan Goodliffe <dan@randomdan.homeip.net>2026-04-20 20:32:32 +0100
committerDan Goodliffe <dan@randomdan.homeip.net>2026-04-20 20:34:54 +0100
commit7a66f1241f4a6ec570a5c41490ee3698eeeaf66e (patch)
tree04e382d2d3f7cb7b5e99140990409b67b3e1a448 /src
parent7b148411b127ebf6fdefdb1b0decd2886cdfc17b (diff)
downloadwebstat-7a66f1241f4a6ec570a5c41490ee3698eeeaf66e.tar.bz2
webstat-7a66f1241f4a6ec570a5c41490ee3698eeeaf66e.tar.xz
webstat-7a66f1241f4a6ec570a5c41490ee3698eeeaf66e.zip
Revert "Save point only if there are new entities"
This reverts commit a6d31ff1d8703eae9375b7ec1cd01b323d7e8e6e.
Diffstat (limited to 'src')
-rw-r--r--src/ingestor.cpp11
1 files changed, 4 insertions, 7 deletions
diff --git a/src/ingestor.cpp b/src/ingestor.cpp
index 33af8cf..cc5270f 100644
--- a/src/ingestor.cpp
+++ b/src/ingestor.cpp
@@ -299,17 +299,14 @@ namespace WebStat {
auto valuesEntities = entities(values);
fillKnownEntities(valuesEntities);
try {
- std::optional<DB::TransactionScope> lineTx;
- if (!std::ranges::all_of(valuesEntities, &std::optional<EntityId>::has_value, &Entity::id)) {
- lineTx.emplace(*dbconn);
- storeNewEntities(dbconn, valuesEntities);
- existingEntities.insert_range(valuesEntities | entityIds);
- }
+ DB::TransactionScope lineTx {*dbconn};
+ storeNewEntities(dbconn, valuesEntities);
+ existingEntities.insert_range(valuesEntities | entityIds);
storeLogLine(dbconn, values);
}
catch (const DB::Error & originalError) {
try {
- DB::TransactionScope dbtx {*dbconn};
+ DB::TransactionScope lineTx {*dbconn};
auto uninsertableLine = ToEntity<EntityType::UninsertableLine> {}(line);
storeNewEntity(dbconn, uninsertableLine);
log(LOG_NOTICE,