From 3151fa7a647ba449868ca1731bdbd29d7f84797a Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Sun, 6 Jan 2019 18:56:49 +0000 Subject: Don't mix and match [a]sync read/write operations Hopefully prevents deadlocking when async writes saturate the thread pool when a read operation occurs. --- netfs/fuse/fuseFiles.cpp | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/netfs/fuse/fuseFiles.cpp b/netfs/fuse/fuseFiles.cpp index 858a0a9..e56ce0b 100644 --- a/netfs/fuse/fuseFiles.cpp +++ b/netfs/fuse/fuseFiles.cpp @@ -147,14 +147,21 @@ int FuseApp::read(const char *, char * buf, size_t s, off_t o, struct fuse_file_info * fi) { try { + auto cpy = [buf](const auto && data) { + memcpy(buf, &data.front(), data.size()); + return data.size(); + }; auto of = getProxy(fi->fh); auto remote = of->remote; - auto data = (fcr->Async) ? - waitOnWriteRangeAndThen(s, o, of, [o, s, &remote](const auto &){ - return remote->read(o, s); - }) : remote->read(o, s); - memcpy(buf, &data.front(), data.size()); - return data.size(); + if (fcr->Async) { + auto p = waitOnWriteRangeAndThen>(s, o, of, [o, s, &remote](const auto &){ + return remote->readAsync(o, s); + }); + return cpy(p.get()); + } + else { + return cpy(remote->read(o, s)); + } } catch (SystemError & e) { return -e.syserrno; -- cgit v1.2.3