From 1a8117e9de2101e24c7b1ab9d0b794f71dec4c77 Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Sat, 24 Jul 2021 14:21:11 +0100 Subject: Remove any default implementation for EventHandlerBase --- lib/eventHandlerBase.cpp | 7 +------ lib/eventHandlerBase.h | 5 ----- lib/output/dumpToConsole.cpp | 2 +- lib/output/dumpToConsole.h | 5 +++++ 4 files changed, 7 insertions(+), 12 deletions(-) diff --git a/lib/eventHandlerBase.cpp b/lib/eventHandlerBase.cpp index 56fad53..07d2c6a 100644 --- a/lib/eventHandlerBase.cpp +++ b/lib/eventHandlerBase.cpp @@ -2,12 +2,7 @@ #include namespace MyGrate { - void - EventHandlerBase::tableMap(MyGrate::MariaDB_Event_Ptr event) - { - tableMaps.insert_or_assign(event->event.table_map.table_id, std::move(event)); - } - + void EventHandlerBase::tableMap(MyGrate::MariaDB_Event_Ptr) { } void EventHandlerBase::insertRow(MariaDB_Event_Ptr) { } void EventHandlerBase::updateRow(MariaDB_Event_Ptr) { } void EventHandlerBase::deleteRow(MariaDB_Event_Ptr) { } diff --git a/lib/eventHandlerBase.h b/lib/eventHandlerBase.h index 4bb2396..8f17e69 100644 --- a/lib/eventHandlerBase.h +++ b/lib/eventHandlerBase.h @@ -13,11 +13,6 @@ namespace MyGrate { virtual void insertRow(MariaDB_Event_Ptr); virtual void updateRow(MariaDB_Event_Ptr); virtual void deleteRow(MariaDB_Event_Ptr); - - protected: - using TableId = decltype(st_mariadb_rpl_table_map_event::table_id); - using TableMaps = std::map; - TableMaps tableMaps; }; } diff --git a/lib/output/dumpToConsole.cpp b/lib/output/dumpToConsole.cpp index 949c16f..656063b 100644 --- a/lib/output/dumpToConsole.cpp +++ b/lib/output/dumpToConsole.cpp @@ -17,7 +17,7 @@ namespace MyGrate::Output { { const auto & tm = event->event.table_map; scprintf<"Table map %?.%? -> %?\n">(std::cout, tm.database, tm.table, tm.table_id); - EventHandlerBase::tableMap(std::move(event)); + tableMaps.insert_or_assign(event->event.table_map.table_id, std::move(event)); } void diff --git a/lib/output/dumpToConsole.h b/lib/output/dumpToConsole.h index e3d51b6..bbbac44 100644 --- a/lib/output/dumpToConsole.h +++ b/lib/output/dumpToConsole.h @@ -16,8 +16,13 @@ namespace MyGrate::Output { void deleteRow(MyGrate::MariaDB_Event_Ptr event) override; private: + using TableId = decltype(st_mariadb_rpl_table_map_event::table_id); + using TableMaps = std::map; + void dumpRowData(const st_mariadb_rpl_rows_event & row) const; void dumpRowPairData(const st_mariadb_rpl_rows_event & row) const; + + TableMaps tableMaps; }; } -- cgit v1.2.3