summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Goodliffe <dan@randomdan.homeip.net>2021-09-07 01:16:24 +0100
committerDan Goodliffe <dan@randomdan.homeip.net>2021-09-07 01:16:24 +0100
commitcb55ccddd891783a11224697b4c931e0ad851550 (patch)
treed2a5f11c9a8d6d658339bdb40cda148b28e23643
parentboost::mpl::list not included, use std::tuple (diff)
downloadlibdbpp-cb55ccddd891783a11224697b4c931e0ad851550.tar.bz2
libdbpp-cb55ccddd891783a11224697b4c931e0ad851550.tar.xz
libdbpp-cb55ccddd891783a11224697b4c931e0ad851550.zip
Add missing virtual destructor
-rw-r--r--Jamroot.jam1
-rw-r--r--libdbpp/column.h2
2 files changed, 3 insertions, 0 deletions
diff --git a/Jamroot.jam b/Jamroot.jam
index 2026f3c..b13bf61 100644
--- a/Jamroot.jam
+++ b/Jamroot.jam
@@ -14,6 +14,7 @@ project
<variant>release:<lto>on
<variant>debug:<warnings>extra
<variant>debug:<warnings-as-errors>on
+ <variant>debug:<cflags>-Wnon-virtual-dtor
<variant>coverage:<coverage>on
<toolset>tidy:<checkxx>boost-*
<toolset>tidy:<checkxx>bugprone-*
diff --git a/libdbpp/column.h b/libdbpp/column.h
index 4008a81..e4c6895 100644
--- a/libdbpp/column.h
+++ b/libdbpp/column.h
@@ -15,6 +15,8 @@ namespace DB {
/// Abstract class for something that can handle field data. See Column::apply.
class DLL_PUBLIC HandleField {
public:
+ virtual ~HandleField() = default;
+
/// The field is null.
virtual void null() = 0;
/// The field contains text data.