diff options
| author | Dan Goodliffe <dan@randomdan.homeip.net> | 2019-02-17 16:23:11 +0000 |
|---|---|---|
| committer | Dan Goodliffe <dan@randomdan.homeip.net> | 2019-02-17 16:23:11 +0000 |
| commit | 41eced6cc768422be8e2a981180b7af687b350a8 (patch) | |
| tree | d6bd1780f6bfe344ae56fbc613f4353c8344e682 | |
| parent | Enable hicpp checks and fix accordingly (diff) | |
| download | libdbpp-41eced6cc768422be8e2a981180b7af687b350a8.tar.bz2 libdbpp-41eced6cc768422be8e2a981180b7af687b350a8.tar.xz libdbpp-41eced6cc768422be8e2a981180b7af687b350a8.zip | |
Enable performance checks and fix accordingly
| -rw-r--r-- | Jamroot.jam | 1 | ||||
| -rw-r--r-- | libdbpp/mockDatabase.cpp | 2 | ||||
| -rw-r--r-- | libdbpp/unittests/testUtils.cpp | 3 |
3 files changed, 4 insertions, 2 deletions
diff --git a/Jamroot.jam b/Jamroot.jam index 7e91686..b4bcd7d 100644 --- a/Jamroot.jam +++ b/Jamroot.jam @@ -21,6 +21,7 @@ project <toolset>tidy:<checkxx>misc-* <toolset>tidy:<checkxx>modernize-* <toolset>tidy:<checkxx>hicpp-* + <toolset>tidy:<checkxx>performance-* ; build-project libdbpp ; diff --git a/libdbpp/mockDatabase.cpp b/libdbpp/mockDatabase.cpp index 7f06b6c..f9c395b 100644 --- a/libdbpp/mockDatabase.cpp +++ b/libdbpp/mockDatabase.cpp @@ -27,7 +27,7 @@ MockDatabase::PlaySchemaScripts(const std::vector<std::filesystem::path> & ss) c { auto conn = ConnectionPtr(openConnection()); try { - for (auto s : ss) { + for (const auto & s : ss) { conn->beginTx(); PlaySchemaScript(conn.get(), s); conn->commitTx(); diff --git a/libdbpp/unittests/testUtils.cpp b/libdbpp/unittests/testUtils.cpp index 416d359..483f58b 100644 --- a/libdbpp/unittests/testUtils.cpp +++ b/libdbpp/unittests/testUtils.cpp @@ -352,6 +352,7 @@ BOOST_AUTO_TEST_CASE( testBlobCompare ) std::vector<S> buf1(20, {4, 8}); DB::Blob vec1(buf1); + // NOLINTNEXTLINE(performance-unnecessary-copy-initialization) std::vector<S> buf2(buf1); DB::Blob vec2(buf2); @@ -373,7 +374,7 @@ testExtractT(DB::Row<T> row) { template<typename T> void -testExtractT(DB::SelectCommandPtr sel) { +testExtractT(const DB::SelectCommandPtr & sel) { // test default construct T test; (void)test; |