From 3526af7ec50e46aaa73d038566f42554f70f27b0 Mon Sep 17 00:00:00 2001
From: Dan Goodliffe <dan@randomdan.homeip.net>
Date: Mon, 4 Aug 2025 19:48:20 +0100
Subject: Fix a lot of clang-tidy warnings

---
 libpqpp/pq-binarycolumn.cpp | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

(limited to 'libpqpp/pq-binarycolumn.cpp')

diff --git a/libpqpp/pq-binarycolumn.cpp b/libpqpp/pq-binarycolumn.cpp
index 761bf0b..4c7de22 100644
--- a/libpqpp/pq-binarycolumn.cpp
+++ b/libpqpp/pq-binarycolumn.cpp
@@ -8,25 +8,25 @@
 #include <error.h>
 #include <server/catalog/pg_type_d.h>
 
-PQ::BinaryColumn::BinaryColumn(const PQ::SelectBase * s, unsigned int f) : PQ::Column(s, f) { }
+PQ::BinaryColumn::BinaryColumn(const PQ::SelectBase * select, unsigned int field) : PQ::Column(select, field) { }
 
 template<std::integral T>
 inline T
 PQ::BinaryColumn::valueAs() const
 {
-	T v {};
-	std::memcpy(&v, value(), sizeof(T));
+	T outValue {};
+	std::memcpy(&outValue, value(), sizeof(T));
 	if constexpr (std::endian::native != std::endian::big && sizeof(T) > 1) {
-		return std::byteswap(v);
+		return std::byteswap(outValue);
 	}
-	return v;
+	return outValue;
 }
 
 void
-PQ::BinaryColumn::apply(DB::HandleField & h) const
+PQ::BinaryColumn::apply(DB::HandleField & handler) const
 {
 	if (isNull()) {
-		h.null();
+		handler.null();
 		return;
 	}
 	switch (oid) {
@@ -34,22 +34,22 @@ PQ::BinaryColumn::apply(DB::HandleField & h) const
 		case VARCHAROID:
 		case TEXTOID:
 		case XMLOID:
-			h.string({value(), length()});
+			handler.string({value(), length()});
 			break;
 		case BOOLOID:
-			h.boolean(valueAs<bool>());
+			handler.boolean(valueAs<bool>());
 			break;
 		case INT2OID:
-			h.integer(valueAs<int16_t>());
+			handler.integer(valueAs<int16_t>());
 			break;
 		case INT4OID:
-			h.integer(valueAs<int32_t>());
+			handler.integer(valueAs<int32_t>());
 			break;
 		case INT8OID:
-			h.integer(valueAs<int64_t>());
+			handler.integer(valueAs<int64_t>());
 			break;
 		case BYTEAOID:
-			h.blob(DB::Blob(value(), length()));
+			handler.blob(DB::Blob(value(), length()));
 			break;
 		default:
 			throw DB::ColumnTypeNotSupported();
-- 
cgit v1.2.3