From ad5108bd5d8c91bc8d3cab0ab6240c4c6dc71ebc Mon Sep 17 00:00:00 2001
From: Dan Goodliffe <dan@randomdan.homeip.net>
Date: Thu, 27 Mar 2025 23:39:11 +0000
Subject: Fix up removeAll and test with more complex hierarchy

---
 lib/collection.h | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

(limited to 'lib')

diff --git a/lib/collection.h b/lib/collection.h
index 853b982..5f39e71 100644
--- a/lib/collection.h
+++ b/lib/collection.h
@@ -115,14 +115,24 @@ public:
 	}
 
 	template<typename T>
-		requires(std::is_convertible_v<T *, Others *> || ...)
+		requires std::is_base_of_v<Object, T>
 	auto
 	removeAll()
 	{
-		std::get<OtherObjects<T>>(otherObjects).clear();
-		return std::erase_if(objects, [](auto && op) {
-			return dynamic_cast<T *>(op.get());
-		});
+		auto removeAllFrom = [](auto & container) {
+			if constexpr (std::is_base_of_v<T, decltype(std::to_address(container.front()))>) {
+				const auto size = container.size();
+				container.clear();
+				return size;
+			}
+			else {
+				return std::erase_if(container, [](auto && objPtr) -> bool {
+					return dynamic_cast<const T *>(std::to_address(objPtr));
+				});
+			}
+		};
+		(removeAllFrom(std::get<OtherObjects<Others>>(otherObjects)), ...);
+		return removeAllFrom(objects);
 	}
 
 	void
-- 
cgit v1.2.3