From 625b78bba16dcbbe97fa84bbf8f2273472d79ade Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Thu, 6 Mar 2025 00:25:22 +0000 Subject: Pass frustum into render functions Support for culling objects outside the view frustum --- gfx/gl/sceneProvider.h | 3 ++- gfx/gl/sceneRenderer.cpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'gfx/gl') diff --git a/gfx/gl/sceneProvider.h b/gfx/gl/sceneProvider.h index f5e8e99..93b384f 100644 --- a/gfx/gl/sceneProvider.h +++ b/gfx/gl/sceneProvider.h @@ -5,6 +5,7 @@ class SceneRenderer; class ShadowMapper; class SceneShader; +class Frustum; class SceneProvider { public: @@ -12,7 +13,7 @@ public: virtual ~SceneProvider() = default; DEFAULT_MOVE_COPY(SceneProvider); - virtual void content(const SceneShader &) const = 0; + virtual void content(const SceneShader &, const Frustum &) const = 0; virtual void environment(const SceneShader &, const SceneRenderer &) const; virtual void lights(const SceneShader &) const = 0; virtual void shadows(const ShadowMapper &) const; diff --git a/gfx/gl/sceneRenderer.cpp b/gfx/gl/sceneRenderer.cpp index b2a7d78..188c4fd 100644 --- a/gfx/gl/sceneRenderer.cpp +++ b/gfx/gl/sceneRenderer.cpp @@ -71,7 +71,7 @@ SceneRenderer::render(const SceneProvider & scene) const glEnable(GL_DEPTH_TEST); glClearColor(0, 0, 0, 1); glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); - scene.content(shader); + scene.content(shader, camera); // Environment pass - // * ambient - clears illumination texture - see setAmbientLight -- cgit v1.2.3 From bf1d591a52428491dfcfe2b5c717adbec9aba768 Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Mon, 10 Mar 2025 00:19:04 +0000 Subject: Simplify ShadowMapper with AxisAlignedBoundingBox --- gfx/gl/shadowMapper.cpp | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) (limited to 'gfx/gl') diff --git a/gfx/gl/shadowMapper.cpp b/gfx/gl/shadowMapper.cpp index 908dbdb..231f203 100644 --- a/gfx/gl/shadowMapper.cpp +++ b/gfx/gl/shadowMapper.cpp @@ -1,6 +1,7 @@ #include "shadowMapper.h" #include "collections.h" #include "game/gamestate.h" +#include "gfx/aabb.h" #include "gfx/gl/shaders/fs-shadowDynamicPointInstWithTextures.h" #include "gfx/gl/shaders/fs-shadowDynamicPointStencil.h" #include "gfx/gl/shaders/gs-commonShadowPoint.h" @@ -19,7 +20,6 @@ #include "maths.h" #include "sceneProvider.h" #include "sceneShader.h" -#include "sorting.h" #include #include #include @@ -102,23 +102,16 @@ ShadowMapper::update(const SceneProvider & scene, const LightDirection & dir, co const auto bandViewExtents = getBandViewExtents(camera, lightViewDir); Definitions out; Sizes sizes; - std::transform(bandViewExtents.begin(), std::prev(bandViewExtents.end()), std::next(bandViewExtents.begin()), - std::back_inserter(out), - [bands = bandViewExtents.size() - 2, &lightViewDir, &sizes](const auto & near, const auto & far) mutable { - const auto extents_minmax - = [extents = std::span {near.begin(), far.end()}](auto && comp, RelativeDistance extra) { - const auto mm = std::minmax_element(extents.begin(), extents.end(), comp); - return std::make_pair(comp.get(*mm.first) - extra, comp.get(*mm.second) + extra); - }; - const std::array extents = {extents_minmax(CompareBy {0}, 0), extents_minmax(CompareBy {1}, 0), - extents_minmax(CompareBy {2}, 10'000)}; - - const auto lightProjection = [](const auto & x, const auto & y, const auto & z) { - return glm::ortho(x.first, x.second, y.first, y.second, -z.second, -z.first); - }(extents[0], extents[1], extents[2]); - - sizes.emplace_back(extents[0].second - extents[0].first, extents[1].second - extents[1].first, - extents[2].second - extents[2].first); + using ExtentsBoundingBox = AxisAlignedBoundingBox; + std::ranges::transform(bandViewExtents | std::views::pairwise, std::back_inserter(out), + [&lightViewDir, &sizes](const auto & band) mutable { + const auto & [near, far] = band; + auto extents = ExtentsBoundingBox::fromPoints(std::span {near.begin(), far.end()}); + extents.min.z -= 10'000.F; + extents.max.z += 10'000.F; + const auto lightProjection = glm::ortho( + extents.min.x, extents.max.x, extents.min.y, extents.max.y, -extents.max.z, -extents.min.z); + sizes.emplace_back(extents.max - extents.min); return lightProjection * lightViewDir; }); for (const auto p : std::initializer_list { -- cgit v1.2.3 From 194148abd9ab89a5a514a37b7717b7c4de6aa758 Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Mon, 10 Mar 2025 02:12:16 +0000 Subject: Pass a Frustum to shadow renderers The frustum might not be correct at this stage. --- game/scenary/foliage.cpp | 2 +- game/scenary/foliage.h | 2 +- game/terrain.cpp | 2 +- game/terrain.h | 2 +- game/vehicles/railVehicleClass.cpp | 2 +- game/vehicles/railVehicleClass.h | 2 +- gfx/aabb.h | 2 +- gfx/gl/sceneProvider.cpp | 2 +- gfx/gl/sceneProvider.h | 2 +- gfx/gl/shadowMapper.cpp | 9 ++++++++- gfx/renderable.cpp | 2 +- gfx/renderable.h | 2 +- test/test-assetFactory.cpp | 4 ++-- test/test-geoData.cpp | 4 ++-- test/test-render.cpp | 14 +++++++------- ui/gameMainWindow.cpp | 6 +++--- ui/gameMainWindow.h | 2 +- 17 files changed, 34 insertions(+), 27 deletions(-) (limited to 'gfx/gl') diff --git a/game/scenary/foliage.cpp b/game/scenary/foliage.cpp index c1bf9b9..159a078 100644 --- a/game/scenary/foliage.cpp +++ b/game/scenary/foliage.cpp @@ -41,7 +41,7 @@ Foliage::render(const SceneShader & shader, const Frustum &) const } void -Foliage::shadows(const ShadowMapper & mapper) const +Foliage::shadows(const ShadowMapper & mapper, const Frustum &) const { if (const auto count = instances.size()) { const auto dimensions = bodyMesh->getDimensions(); diff --git a/game/scenary/foliage.h b/game/scenary/foliage.h index 422c7aa..71bc734 100644 --- a/game/scenary/foliage.h +++ b/game/scenary/foliage.h @@ -25,7 +25,7 @@ public: mutable InstanceVertices instances; void render(const SceneShader &, const Frustum &) const override; - void shadows(const ShadowMapper &) const override; + void shadows(const ShadowMapper &, const Frustum &) const override; void updateStencil(const ShadowStenciller &) const override; glTexture shadowStencil = ShadowStenciller::createStencilTexture(256, 256); diff --git a/game/terrain.cpp b/game/terrain.cpp index 577d9e5..e9e9463 100644 --- a/game/terrain.cpp +++ b/game/terrain.cpp @@ -128,7 +128,7 @@ Terrain::render(const SceneShader & shader, const Frustum & frustum) const } void -Terrain::shadows(const ShadowMapper & shadowMapper) const +Terrain::shadows(const ShadowMapper & shadowMapper, const Frustum &) const { shadowMapper.landmess.use(); for (const auto & [surface, sab] : meshes) { diff --git a/game/terrain.h b/game/terrain.h index 5f03634..eaec01d 100644 --- a/game/terrain.h +++ b/game/terrain.h @@ -17,7 +17,7 @@ public: } void render(const SceneShader & shader, const Frustum &) const override; - void shadows(const ShadowMapper &) const override; + void shadows(const ShadowMapper &, const Frustum &) const override; void tick(TickDuration) override; diff --git a/game/vehicles/railVehicleClass.cpp b/game/vehicles/railVehicleClass.cpp index 179b570..162a29a 100644 --- a/game/vehicles/railVehicleClass.cpp +++ b/game/vehicles/railVehicleClass.cpp @@ -47,7 +47,7 @@ RailVehicleClass::render(const SceneShader & shader, const Frustum &) const } void -RailVehicleClass::shadows(const ShadowMapper & mapper) const +RailVehicleClass::shadows(const ShadowMapper & mapper, const Frustum &) const { if (const auto count = static_cast(instances.size())) { mapper.dynamicPointInst.use(); diff --git a/game/vehicles/railVehicleClass.h b/game/vehicles/railVehicleClass.h index 2c1fd2b..6eb4ca5 100644 --- a/game/vehicles/railVehicleClass.h +++ b/game/vehicles/railVehicleClass.h @@ -15,7 +15,7 @@ class Location; class RailVehicleClass : public Renderable, public Asset { public: void render(const SceneShader & shader, const Frustum &) const override; - void shadows(const ShadowMapper & shadowMapper) const override; + void shadows(const ShadowMapper & shadowMapper, const Frustum &) const override; struct LocationVertex { glm::mat3 body, front, back; diff --git a/gfx/aabb.h b/gfx/aabb.h index a661f66..ce15a0f 100644 --- a/gfx/aabb.h +++ b/gfx/aabb.h @@ -37,5 +37,5 @@ public: })); } - V min, max; + V min {}, max {}; }; diff --git a/gfx/gl/sceneProvider.cpp b/gfx/gl/sceneProvider.cpp index 4e271db..e01532e 100644 --- a/gfx/gl/sceneProvider.cpp +++ b/gfx/gl/sceneProvider.cpp @@ -9,6 +9,6 @@ SceneProvider::environment(const SceneShader &, const SceneRenderer & renderer) } void -SceneProvider::shadows(const ShadowMapper &) const +SceneProvider::shadows(const ShadowMapper &, const Frustum &) const { } diff --git a/gfx/gl/sceneProvider.h b/gfx/gl/sceneProvider.h index 93b384f..f6b7009 100644 --- a/gfx/gl/sceneProvider.h +++ b/gfx/gl/sceneProvider.h @@ -16,5 +16,5 @@ public: virtual void content(const SceneShader &, const Frustum &) const = 0; virtual void environment(const SceneShader &, const SceneRenderer &) const; virtual void lights(const SceneShader &) const = 0; - virtual void shadows(const ShadowMapper &) const; + virtual void shadows(const ShadowMapper &, const Frustum &) const; }; diff --git a/gfx/gl/shadowMapper.cpp b/gfx/gl/shadowMapper.cpp index 231f203..dc461e0 100644 --- a/gfx/gl/shadowMapper.cpp +++ b/gfx/gl/shadowMapper.cpp @@ -118,7 +118,14 @@ ShadowMapper::update(const SceneProvider & scene, const LightDirection & dir, co &landmess, &dynamicPoint, &dynamicPointInst, &dynamicPointInstWithTextures, &stencilShadowProgram}) { p->setView(out, sizes, lightViewPoint); } - scene.shadows(*this); + ExtentsBoundingBox extents; + for (const auto & point : bandViewExtents.back()) { + extents += point; + } + const auto lightProjection + = glm::ortho(extents.min.x, extents.max.x, extents.min.y, extents.max.y, -extents.max.z, -extents.min.z); + Frustum frustum {lightViewPoint, lightViewDir, lightProjection}; + scene.shadows(*this, frustum); glCullFace(GL_BACK); diff --git a/gfx/renderable.cpp b/gfx/renderable.cpp index 3594968..27f2459 100644 --- a/gfx/renderable.cpp +++ b/gfx/renderable.cpp @@ -6,7 +6,7 @@ Renderable::lights(const SceneShader &) const } void -Renderable::shadows(const ShadowMapper &) const +Renderable::shadows(const ShadowMapper &, const Frustum &) const { } diff --git a/gfx/renderable.h b/gfx/renderable.h index 9fbeccd..140c570 100644 --- a/gfx/renderable.h +++ b/gfx/renderable.h @@ -15,7 +15,7 @@ public: virtual void render(const SceneShader & shader, const Frustum &) const = 0; virtual void lights(const SceneShader & shader) const; - virtual void shadows(const ShadowMapper & shadowMapper) const; + virtual void shadows(const ShadowMapper & shadowMapper, const Frustum &) const; virtual void updateStencil(const ShadowStenciller & lightDir) const; }; diff --git a/test/test-assetFactory.cpp b/test/test-assetFactory.cpp index 02f0202..9bade82 100644 --- a/test/test-assetFactory.cpp +++ b/test/test-assetFactory.cpp @@ -58,10 +58,10 @@ public: } void - shadows(const ShadowMapper & mapper) const override + shadows(const ShadowMapper & mapper, const Frustum & frustum) const override { mapper.dynamicPoint.use(Location {{0, 0, 0}, {0, 0, 0}}); - objects.apply(&Renderable::shadows, mapper); + objects.apply(&Renderable::shadows, mapper, frustum); } void diff --git a/test/test-geoData.cpp b/test/test-geoData.cpp index fb8b5c5..e3ef9ad 100644 --- a/test/test-geoData.cpp +++ b/test/test-geoData.cpp @@ -273,9 +273,9 @@ BOOST_DATA_TEST_CASE(deform, loadFixtureJson("geoData/deform/ } void - shadows(const ShadowMapper & shadowMapper) const override + shadows(const ShadowMapper & shadowMapper, const Frustum & frustum) const override { - terrain.shadows(shadowMapper); + terrain.shadows(shadowMapper, frustum); } }; diff --git a/test/test-render.cpp b/test/test-render.cpp index 080e635..f205b89 100644 --- a/test/test-render.cpp +++ b/test/test-render.cpp @@ -92,12 +92,12 @@ public: } void - shadows(const ShadowMapper & shadowMapper) const override + shadows(const ShadowMapper & shadowMapper, const Frustum & frustum) const override { - terrain->shadows(shadowMapper); - std::ranges::for_each(gameState->assets, [&shadowMapper](const auto & asset) { + terrain->shadows(shadowMapper, frustum); + std::ranges::for_each(gameState->assets, [&shadowMapper, &frustum](const auto & asset) { if (const auto renderable = std::dynamic_pointer_cast(asset.second)) { - renderable->shadows(shadowMapper); + renderable->shadows(shadowMapper, frustum); } }); } @@ -190,9 +190,9 @@ BOOST_AUTO_TEST_CASE(terrain) } void - shadows(const ShadowMapper & shadowMapper) const override + shadows(const ShadowMapper & shadowMapper, const Frustum & frustum) const override { - terrain->shadows(shadowMapper); + terrain->shadows(shadowMapper, frustum); } }; @@ -237,7 +237,7 @@ BOOST_AUTO_TEST_CASE(railnet) } void - shadows(const ShadowMapper &) const override + shadows(const ShadowMapper &, const Frustum &) const override { } }; diff --git a/ui/gameMainWindow.cpp b/ui/gameMainWindow.cpp index 3403afa..f63137c 100644 --- a/ui/gameMainWindow.cpp +++ b/ui/gameMainWindow.cpp @@ -78,12 +78,12 @@ GameMainWindow::lights(const SceneShader & shader) const } void -GameMainWindow::shadows(const ShadowMapper & shadowMapper) const +GameMainWindow::shadows(const ShadowMapper & shadowMapper, const Frustum & frustum) const { for (const auto & [id, asset] : gameState->assets) { if (const auto r = std::dynamic_pointer_cast(asset)) { - r->shadows(shadowMapper); + r->shadows(shadowMapper, frustum); } } - gameState->world.apply(&Renderable::shadows, shadowMapper); + gameState->world.apply(&Renderable::shadows, shadowMapper, frustum); } diff --git a/ui/gameMainWindow.h b/ui/gameMainWindow.h index 112d23b..43980e8 100644 --- a/ui/gameMainWindow.h +++ b/ui/gameMainWindow.h @@ -20,5 +20,5 @@ private: void content(const SceneShader &, const Frustum &) const override; void environment(const SceneShader &, const SceneRenderer &) const override; void lights(const SceneShader &) const override; - void shadows(const ShadowMapper &) const override; + void shadows(const ShadowMapper &, const Frustum &) const override; }; -- cgit v1.2.3 From 49b5e522e64020c2ce41e3dd86de7c87680d180d Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Tue, 11 Mar 2025 00:49:06 +0000 Subject: Initialise shadow bounding box to light view point Then extended to cover the view extents. --- gfx/gl/shadowMapper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gfx/gl') diff --git a/gfx/gl/shadowMapper.cpp b/gfx/gl/shadowMapper.cpp index dc461e0..28ef0ae 100644 --- a/gfx/gl/shadowMapper.cpp +++ b/gfx/gl/shadowMapper.cpp @@ -118,7 +118,7 @@ ShadowMapper::update(const SceneProvider & scene, const LightDirection & dir, co &landmess, &dynamicPoint, &dynamicPointInst, &dynamicPointInstWithTextures, &stencilShadowProgram}) { p->setView(out, sizes, lightViewPoint); } - ExtentsBoundingBox extents; + ExtentsBoundingBox extents {lightViewPoint, lightViewPoint}; for (const auto & point : bandViewExtents.back()) { extents += point; } -- cgit v1.2.3 From d0ea1598abdb55c98ca8daea857f6fca77119928 Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Tue, 11 Mar 2025 00:59:34 +0000 Subject: Rebalance shadow band distribution Extends the initial band from around 34m to around 100m. --- gfx/gl/shadowMapper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gfx/gl') diff --git a/gfx/gl/shadowMapper.cpp b/gfx/gl/shadowMapper.cpp index 28ef0ae..6525f76 100644 --- a/gfx/gl/shadowMapper.cpp +++ b/gfx/gl/shadowMapper.cpp @@ -56,7 +56,7 @@ constexpr auto shadowBands = [](const float scaleFactor, std::integer_sequence) { const auto base = 10'000'000 / pow(scaleFactor, sizeof...(ints) - 1); return std::array {1, static_cast((base * pow(scaleFactor, ints)))...}; - }(6.6F, std::make_integer_sequence()); + }(4.6F, std::make_integer_sequence()); static_assert(shadowBands.front() == 1); static_assert(shadowBands.back() == 10'000'000); -- cgit v1.2.3