From e3b587143dfc4e8b97d8916ef1d4bcd1dd43734c Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Sat, 6 Jan 2024 12:06:26 +0000 Subject: Simplified RailVehicle::intersectRay --- game/vehicles/railVehicle.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'game') diff --git a/game/vehicles/railVehicle.cpp b/game/vehicles/railVehicle.cpp index 6653333..94f72e4 100644 --- a/game/vehicles/railVehicle.cpp +++ b/game/vehicles/railVehicle.cpp @@ -49,16 +49,16 @@ RailVehicle::intersectRay(const Ray & ray, BaryPosition & baryPos, RelativeDista constexpr const auto X = 1350.F; const auto Y = this->rvClass->length / 2.F; constexpr const auto Z = 3900.F; - const auto moveBy = location.getRotationTransform(); + const glm::mat3 moveBy = location.getRotationTransform(); const std::array cornerVertices {{ - location.position() + GlobalPosition3D(moveBy * glm::vec4 {-X, Y, 0, 1}).xyz(), // LFB - location.position() + GlobalPosition3D(moveBy * glm::vec4 {X, Y, 0, 1}).xyz(), // RFB - location.position() + GlobalPosition3D(moveBy * glm::vec4 {-X, Y, Z, 1}).xyz(), // LFT - location.position() + GlobalPosition3D(moveBy * glm::vec4 {X, Y, Z, 1}).xyz(), // RFT - location.position() + GlobalPosition3D(moveBy * glm::vec4 {-X, -Y, 0, 1}).xyz(), // LBB - location.position() + GlobalPosition3D(moveBy * glm::vec4 {X, -Y, 0, 1}).xyz(), // RBB - location.position() + GlobalPosition3D(moveBy * glm::vec4 {-X, -Y, Z, 1}).xyz(), // LBT - location.position() + GlobalPosition3D(moveBy * glm::vec4 {X, -Y, Z, 1}).xyz(), // RBT + location.position() + GlobalPosition3D(moveBy * glm::vec3 {-X, Y, 0}), // LFB + location.position() + GlobalPosition3D(moveBy * glm::vec3 {X, Y, 0}), // RFB + location.position() + GlobalPosition3D(moveBy * glm::vec3 {-X, Y, Z}), // LFT + location.position() + GlobalPosition3D(moveBy * glm::vec3 {X, Y, Z}), // RFT + location.position() + GlobalPosition3D(moveBy * glm::vec3 {-X, -Y, 0}), // LBB + location.position() + GlobalPosition3D(moveBy * glm::vec3 {X, -Y, 0}), // RBB + location.position() + GlobalPosition3D(moveBy * glm::vec3 {-X, -Y, Z}), // LBT + location.position() + GlobalPosition3D(moveBy * glm::vec3 {X, -Y, Z}), // RBT }}; static constexpr const std::array, 10> triangles {{ // Front -- cgit v1.2.3 From dcef947ea986f4ad4633189652abccebdd7aa3f6 Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Sat, 6 Jan 2024 13:03:42 +0000 Subject: Helper to create a cubiod from dimensions --- game/vehicles/railVehicle.cpp | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) (limited to 'game') diff --git a/game/vehicles/railVehicle.cpp b/game/vehicles/railVehicle.cpp index 94f72e4..c720eb6 100644 --- a/game/vehicles/railVehicle.cpp +++ b/game/vehicles/railVehicle.cpp @@ -3,12 +3,12 @@ #include "train.h" #include #include +#include #include #include #include #include #include -#include #include RailVehicle::RailVehicle(RailVehicleClassPtr rvc) : @@ -50,16 +50,10 @@ RailVehicle::intersectRay(const Ray & ray, BaryPosition & baryPos, RelativeDista const auto Y = this->rvClass->length / 2.F; constexpr const auto Z = 3900.F; const glm::mat3 moveBy = location.getRotationTransform(); - const std::array cornerVertices {{ - location.position() + GlobalPosition3D(moveBy * glm::vec3 {-X, Y, 0}), // LFB - location.position() + GlobalPosition3D(moveBy * glm::vec3 {X, Y, 0}), // RFB - location.position() + GlobalPosition3D(moveBy * glm::vec3 {-X, Y, Z}), // LFT - location.position() + GlobalPosition3D(moveBy * glm::vec3 {X, Y, Z}), // RFT - location.position() + GlobalPosition3D(moveBy * glm::vec3 {-X, -Y, 0}), // LBB - location.position() + GlobalPosition3D(moveBy * glm::vec3 {X, -Y, 0}), // RBB - location.position() + GlobalPosition3D(moveBy * glm::vec3 {-X, -Y, Z}), // LBT - location.position() + GlobalPosition3D(moveBy * glm::vec3 {X, -Y, Z}), // RBT - }}; + const auto cornerVertices + = cuboidCorners(-X, X, -Y, Y, 0.F, Z) * [&moveBy, this](const auto & corner) -> Position3D { + return location.position() + GlobalPosition3D(moveBy * corner); + }; static constexpr const std::array, 10> triangles {{ // Front {0, 1, 2}, -- cgit v1.2.3 From 95eed94c9294f719724283e672cc7c83b2abd282 Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Sun, 7 Jan 2024 01:10:26 +0000 Subject: Unified crossProduct --- game/geoData.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'game') diff --git a/game/geoData.cpp b/game/geoData.cpp index 97f4a26..816733f 100644 --- a/game/geoData.cpp +++ b/game/geoData.cpp @@ -161,7 +161,7 @@ namespace { positionOnTriangle(const GlobalPosition2D point, const GeoData::Triangle<3> & t) { const CalcPosition3D a = t[1] - t[0], b = t[2] - t[0]; - const auto n = crossInt(a, b); + const auto n = crossProduct(a, b); return {point, ((n.x * t[0].x) + (n.y * t[0].y) + (n.z * t[0].z) - (n.x * point.x) - (n.y * point.y)) / n.z}; } -- cgit v1.2.3 From 6a1df3dfbae98a05e74c646cc216fbc19ffdb6d6 Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Sun, 7 Jan 2024 13:04:31 +0000 Subject: Template Ray on position type --- game/geoData.cpp | 12 ++++++------ game/geoData.h | 4 ++-- game/network/link.cpp | 9 +++++---- game/network/link.h | 8 ++++---- game/network/network.cpp | 7 ++++--- game/network/network.h | 8 ++++---- game/network/network.impl.h | 2 +- game/selectable.h | 5 +++-- game/vehicles/railVehicle.cpp | 6 +++--- game/vehicles/railVehicle.h | 4 ++-- game/vehicles/train.cpp | 4 ++-- game/vehicles/train.h | 4 ++-- 12 files changed, 38 insertions(+), 35 deletions(-) (limited to 'game') diff --git a/game/geoData.cpp b/game/geoData.cpp index 816733f..b30a35b 100644 --- a/game/geoData.cpp +++ b/game/geoData.cpp @@ -194,23 +194,23 @@ GeoData::positionAt(const PointFace & p) const } [[nodiscard]] std::optional -GeoData::intersectRay(const Ray & ray) const +GeoData::intersectRay(const Ray & ray) const { return intersectRay(ray, findPoint(ray.start)); } [[nodiscard]] std::optional -GeoData::intersectRay(const Ray & ray, FaceHandle face) const +GeoData::intersectRay(const Ray & ray, FaceHandle face) const { std::optional out; walkUntil(PointFace {ray.start, face}, - ray.start.xy() + (ray.direction.xy() * RelativePosition2D(upperExtent.xy() - lowerExtent.xy())), + ray.start.xy() + + GlobalPosition2D(ray.direction.xy() * RelativePosition2D(upperExtent.xy() - lowerExtent.xy())), [&out, &ray, this](FaceHandle face) { BaryPosition bari {}; - float dist {}; + RelativeDistance dist {}; const auto t = triangle<3>(face); - if (glm::intersectRayTriangle( - ray.start, ray.direction, t[0], t[1], t[2], bari, dist)) { + if (ray.intersectTriangle(t.x, t.y, t.z, bari, dist)) { out = t * bari; return true; } diff --git a/game/geoData.h b/game/geoData.h index d4d0fb3..e234bfe 100644 --- a/game/geoData.h +++ b/game/geoData.h @@ -74,8 +74,8 @@ public: [[nodiscard]] FaceHandle findPoint(GlobalPosition2D, FaceHandle start) const; [[nodiscard]] GlobalPosition3D positionAt(const PointFace &) const; - [[nodiscard]] std::optional intersectRay(const Ray &) const; - [[nodiscard]] std::optional intersectRay(const Ray &, FaceHandle start) const; + [[nodiscard]] std::optional intersectRay(const Ray &) const; + [[nodiscard]] std::optional intersectRay(const Ray &, FaceHandle start) const; void walk(const PointFace & from, const GlobalPosition2D to, const std::function & op) const; void walkUntil(const PointFace & from, const GlobalPosition2D to, const std::function & op) const; diff --git a/game/network/link.cpp b/game/network/link.cpp index 703a1ca..e8eaea2 100644 --- a/game/network/link.cpp +++ b/game/network/link.cpp @@ -33,9 +33,10 @@ LinkStraight::positionAt(float dist, unsigned char start) const } bool -LinkStraight::intersectRay(const Ray & ray) const +LinkStraight::intersectRay(const Ray & ray) const { - return ray.passesCloseToEdges(std::array {ends.front().node->pos, ends.back().node->pos}, 1.F); + return ray.passesCloseToEdges( + std::array {GlobalPosition3D {ends.front().node->pos}, GlobalPosition3D {ends.back().node->pos}}, 1000); } Location @@ -54,7 +55,7 @@ LinkCurve::positionAt(float dist, unsigned char start) const } bool -LinkCurve::intersectRay(const Ray & ray) const +LinkCurve::intersectRay(const Ray & ray) const { const auto & e0p {ends[0].node->pos}; const auto & e1p {ends[1].node->pos}; @@ -64,7 +65,7 @@ LinkCurve::intersectRay(const Ray & ray) const const auto trans {glm::translate(centreBase)}; auto segCount = static_cast(std::lround(segs)) + 1; - std::vector points; + std::vector points; points.reserve(segCount); for (Position3D swing = {arc.first, centreBase.z - e0p.z, 0.F}; segCount; swing += step, --segCount) { const auto t {trans * glm::rotate(half_pi - swing.x, up) * glm::translate(Position3D {radius, 0.F, swing.y})}; diff --git a/game/network/link.h b/game/network/link.h index 78d3e91..95c141e 100644 --- a/game/network/link.h +++ b/game/network/link.h @@ -10,7 +10,7 @@ #include #include -class Ray; +template class Ray; // Generic network node // something that can be travelled to @@ -45,7 +45,7 @@ public: NO_MOVE(Link); [[nodiscard]] virtual Location positionAt(float dist, unsigned char start) const = 0; - [[nodiscard]] virtual bool intersectRay(const Ray &) const = 0; + [[nodiscard]] virtual bool intersectRay(const Ray &) const = 0; std::array ends; float length; @@ -69,7 +69,7 @@ public: NO_MOVE(LinkStraight); [[nodiscard]] Location positionAt(float dist, unsigned char start) const override; - [[nodiscard]] bool intersectRay(const Ray &) const override; + [[nodiscard]] bool intersectRay(const Ray &) const override; }; LinkStraight::~LinkStraight() = default; @@ -82,7 +82,7 @@ public: NO_MOVE(LinkCurve); [[nodiscard]] Location positionAt(float dist, unsigned char start) const override; - [[nodiscard]] bool intersectRay(const Ray &) const override; + [[nodiscard]] bool intersectRay(const Ray &) const override; Position3D centreBase; float radius; diff --git a/game/network/network.cpp b/game/network/network.cpp index 1ff5b26..d52e804 100644 --- a/game/network/network.cpp +++ b/game/network/network.cpp @@ -49,13 +49,14 @@ Network::candidateNodeAt(Position3D pos) const } Node::Ptr -Network::intersectRayNodes(const Ray & ray) const +Network::intersectRayNodes(const Ray & ray) const { // Click within 2m of a node if (const auto node = std::find_if(nodes.begin(), nodes.end(), [&ray](const Node::Ptr & node) { - Position3D ipos, inorm; - return glm::intersectRaySphere(ray.start, ray.direction, node->pos, 2.F, ipos, inorm); + GlobalPosition3D ipos; + Normal3D inorm; + return ray.intersectSphere(node->pos, 2000, ipos, inorm); }); node != nodes.end()) { return *node; diff --git a/game/network/network.h b/game/network/network.h index 8af06a9..9ce6e81 100644 --- a/game/network/network.h +++ b/game/network/network.h @@ -14,7 +14,7 @@ class Texture; class SceneShader; -class Ray; +template class Ray; template using GenDef = std::tuple...>; using GenCurveDef = GenDef<3, 3, 2>; @@ -32,8 +32,8 @@ public: using NodeInsertion = std::pair; [[nodiscard]] NodeInsertion newNodeAt(Position3D); [[nodiscard]] NodeInsertion candidateNodeAt(Position3D) const; - [[nodiscard]] virtual Link::Ptr intersectRayLinks(const Ray &) const = 0; - [[nodiscard]] virtual Node::Ptr intersectRayNodes(const Ray &) const; + [[nodiscard]] virtual Link::Ptr intersectRayLinks(const Ray &) const = 0; + [[nodiscard]] virtual Node::Ptr intersectRayNodes(const Ray &) const; [[nodiscard]] Link::Nexts routeFromTo(const Link::End &, Position3D) const; [[nodiscard]] Link::Nexts routeFromTo(const Link::End &, const Node::Ptr &) const; @@ -66,7 +66,7 @@ protected: void joinLinks(const Link::Ptr &) const; protected: - [[nodiscard]] Link::Ptr intersectRayLinks(const Ray &) const override; + [[nodiscard]] Link::Ptr intersectRayLinks(const Ray &) const override; public: template diff --git a/game/network/network.impl.h b/game/network/network.impl.h index 8e9e85c..4acbb6d 100644 --- a/game/network/network.impl.h +++ b/game/network/network.impl.h @@ -24,7 +24,7 @@ NetworkOf::joinLinks(const Link::Ptr & l) const template Link::Ptr -NetworkOf::intersectRayLinks(const Ray & ray) const +NetworkOf::intersectRayLinks(const Ray & ray) const { // Click link if (const auto link = std::find_if(links.objects.begin(), links.objects.end(), diff --git a/game/selectable.h b/game/selectable.h index c794461..fc6af4e 100644 --- a/game/selectable.h +++ b/game/selectable.h @@ -4,7 +4,7 @@ #include #include -class Ray; +template class Ray; class Selectable { public: @@ -12,5 +12,6 @@ public: virtual ~Selectable() = default; DEFAULT_MOVE_COPY(Selectable); - [[nodiscard]] virtual bool intersectRay(const Ray &, BaryPosition &, RelativeDistance &) const = 0; + [[nodiscard]] virtual bool intersectRay(const Ray &, BaryPosition &, RelativeDistance &) const + = 0; }; diff --git a/game/vehicles/railVehicle.cpp b/game/vehicles/railVehicle.cpp index c720eb6..985e9f2 100644 --- a/game/vehicles/railVehicle.cpp +++ b/game/vehicles/railVehicle.cpp @@ -44,7 +44,7 @@ RailVehicle::move(const Train * t, float & trailBy) } bool -RailVehicle::intersectRay(const Ray & ray, BaryPosition & baryPos, RelativeDistance & distance) const +RailVehicle::intersectRay(const Ray & ray, BaryPosition & baryPos, RelativeDistance & distance) const { constexpr const auto X = 1350.F; const auto Y = this->rvClass->length / 2.F; @@ -73,7 +73,7 @@ RailVehicle::intersectRay(const Ray & ray, BaryPosition & baryPos, RelativeDista }}; return std::any_of( triangles.begin(), triangles.end(), [&cornerVertices, &ray, &baryPos, &distance](const auto & idx) { - return glm::intersectRayTriangle(ray.start, ray.direction, cornerVertices[idx[0]], - cornerVertices[idx[1]], cornerVertices[idx[2]], baryPos, distance); + return ray.intersectTriangle( + cornerVertices[idx[0]], cornerVertices[idx[1]], cornerVertices[idx[2]], baryPos, distance); }); } diff --git a/game/vehicles/railVehicle.h b/game/vehicles/railVehicle.h index f6e4764..bf1e782 100644 --- a/game/vehicles/railVehicle.h +++ b/game/vehicles/railVehicle.h @@ -7,7 +7,7 @@ #include #include -class Ray; +template class Ray; class Train; class RailVehicle : Selectable, RailVehicleClass::Instance { @@ -16,7 +16,7 @@ public: void move(const Train *, float & trailBy); - [[nodiscard]] bool intersectRay(const Ray &, BaryPosition &, RelativeDistance &) const override; + [[nodiscard]] bool intersectRay(const Ray &, BaryPosition &, RelativeDistance &) const override; RailVehicleClassPtr rvClass; using LV = RailVehicleClass::LocationVertex; diff --git a/game/vehicles/train.cpp b/game/vehicles/train.cpp index 05b2d8a..5bddd61 100644 --- a/game/vehicles/train.cpp +++ b/game/vehicles/train.cpp @@ -9,7 +9,7 @@ #include #include -class Ray; +template class Ray; Location Train::getBogiePosition(float linkDist, float dist) const @@ -20,7 +20,7 @@ Train::getBogiePosition(float linkDist, float dist) const } bool -Train::intersectRay(const Ray & ray, BaryPosition & baryPos, RelativeDistance & distance) const +Train::intersectRay(const Ray & ray, BaryPosition & baryPos, RelativeDistance & distance) const { return applyOne(&RailVehicle::intersectRay, ray, baryPos, distance) != end(); } diff --git a/game/vehicles/train.h b/game/vehicles/train.h index bb668ed..4320103 100644 --- a/game/vehicles/train.h +++ b/game/vehicles/train.h @@ -13,7 +13,7 @@ class SceneShader; class ShadowMapper; -class Ray; +template class Ray; class Train : public Vehicle, public Collection, public Can, public Can { public: @@ -25,7 +25,7 @@ public: return objects.front()->location; } - [[nodiscard]] bool intersectRay(const Ray &, BaryPosition &, RelativeDistance &) const override; + [[nodiscard]] bool intersectRay(const Ray &, BaryPosition &, RelativeDistance &) const override; void tick(TickDuration elapsed) override; void doActivity(Go *, TickDuration) override; -- cgit v1.2.3 From 25c7bec4acd63ebe01b3d1d21fa01ddf382df829 Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Sun, 7 Jan 2024 13:18:56 +0000 Subject: Remove Position3D from RailVehicle --- game/vehicles/railVehicle.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'game') diff --git a/game/vehicles/railVehicle.cpp b/game/vehicles/railVehicle.cpp index 985e9f2..4a1fdab 100644 --- a/game/vehicles/railVehicle.cpp +++ b/game/vehicles/railVehicle.cpp @@ -22,12 +22,12 @@ RailVehicle::RailVehicle(RailVehicleClassPtr rvc) : this->get()->front = l->getRotationTransform(); this->get()->frontPos = l->position(); }, - Position3D {0, rvClass->wheelBase / 2.F, 0}}, + GlobalPosition3D {0, rvClass->wheelBase / 2.F, 0}}, {[this](const BufferedLocation * l) { this->get()->back = l->getRotationTransform(); this->get()->backPos = l->position(); }, - Position3D {0, -rvClass->wheelBase / 2.F, 0}}, + GlobalPosition3D {0, -rvClass->wheelBase / 2.F, 0}}, }} { } @@ -50,8 +50,7 @@ RailVehicle::intersectRay(const Ray & ray, BaryPosition & bary const auto Y = this->rvClass->length / 2.F; constexpr const auto Z = 3900.F; const glm::mat3 moveBy = location.getRotationTransform(); - const auto cornerVertices - = cuboidCorners(-X, X, -Y, Y, 0.F, Z) * [&moveBy, this](const auto & corner) -> Position3D { + const auto cornerVertices = cuboidCorners(-X, X, -Y, Y, 0.F, Z) * [&moveBy, this](const auto & corner) { return location.position() + GlobalPosition3D(moveBy * corner); }; static constexpr const std::array, 10> triangles {{ -- cgit v1.2.3