From c7d16559dc9fc00e610ef24e1c3331678e36f2bd Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Thu, 29 Dec 2022 00:15:10 +0000 Subject: Add missing explicit on constructors --- gfx/gl/program.h | 2 +- gfx/gl/sceneShader.h | 2 +- gfx/gl/shadowMapper.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gfx/gl/program.h b/gfx/gl/program.h index eb10888..fd9edbf 100644 --- a/gfx/gl/program.h +++ b/gfx/gl/program.h @@ -10,7 +10,7 @@ class Location; using ProgramRef = glRef; class Program { public: - template Program(const S &... srcs) + template explicit Program(const S &... srcs) { (glAttachShader(m_program, srcs.compile()), ...); linkAndValidate(); diff --git a/gfx/gl/sceneShader.h b/gfx/gl/sceneShader.h index 62df9bf..9db6ebf 100644 --- a/gfx/gl/sceneShader.h +++ b/gfx/gl/sceneShader.h @@ -9,7 +9,7 @@ class SceneShader { class SceneProgram : public Program { public: template - inline SceneProgram(const S &... srcs) : + inline explicit SceneProgram(const S &... srcs) : Program {srcs...}, viewProjectionLoc {*this, "viewProjection"}, viewPortLoc {*this, "viewPort"} { } diff --git a/gfx/gl/shadowMapper.h b/gfx/gl/shadowMapper.h index 7065ffe..0ce6898 100644 --- a/gfx/gl/shadowMapper.h +++ b/gfx/gl/shadowMapper.h @@ -9,7 +9,7 @@ class Camera; class ShadowMapper { public: - ShadowMapper(const glm::ivec2 & size); + explicit ShadowMapper(const glm::ivec2 & size); static constexpr std::size_t SHADOW_BANDS {4}; template struct Definitions { -- cgit v1.2.3