From 790823f6a81edcafecedb83b0560b1675ac87f1f Mon Sep 17 00:00:00 2001 From: Dan Goodliffe Date: Sun, 8 Mar 2026 16:13:47 +0000 Subject: Remove identifier naming lint comments, gl* is fine --- gfx/gl/glBuffer.h | 3 --- gfx/gl/glVertexArray.h | 9 +++------ lib/glArrays.h | 13 ++----------- 3 files changed, 5 insertions(+), 20 deletions(-) diff --git a/gfx/gl/glBuffer.h b/gfx/gl/glBuffer.h index f43c223..275276f 100644 --- a/gfx/gl/glBuffer.h +++ b/gfx/gl/glBuffer.h @@ -3,7 +3,6 @@ #include "glArrays.h" namespace Impl { - // NOLINTNEXTLINE(readability-identifier-naming) struct glBuffer : Detail::glNamed { void storage(const std::ranges::contiguous_range auto & data, GLenum flags) @@ -21,7 +20,5 @@ namespace Impl { }; } -// NOLINTBEGIN(readability-identifier-naming) template using glBuffers = glManagedArray; using glBuffer = glManagedSingle; -// NOLINTEND(readability-identifier-naming) diff --git a/gfx/gl/glVertexArray.h b/gfx/gl/glVertexArray.h index 3790863..dbe930f 100644 --- a/gfx/gl/glVertexArray.h +++ b/gfx/gl/glVertexArray.h @@ -108,7 +108,6 @@ namespace Impl { GLuint attrib = 0; }; - // NOLINTNEXTLINE(readability-identifier-naming) struct glVertexArray : Detail::glNamed { VertexArrayConfigurator configure() @@ -116,21 +115,19 @@ namespace Impl { return VertexArrayConfigurator {name}; } - template + template void - useBuffer(GLuint binding, const GlAllocated & buffer) const + useBuffer(GLuint binding, const glAllocated & buffer) const requires requires { { buffer.bufferName() } -> std::same_as; } { - using T = typename GlAllocated::value_type; + using T = typename glAllocated::value_type; glVertexArrayVertexBuffer(name, binding, buffer.bufferName(), 0, sizeof(T)); } }; } -// NOLINTBEGIN(readability-identifier-naming) template using glVertexArrays = glManagedArray; using glVertexArray = glManagedSingle; -// NOLINTEND(readability-identifier-naming) diff --git a/lib/glArrays.h b/lib/glArrays.h index 1cf2fbf..93ea992 100644 --- a/lib/glArrays.h +++ b/lib/glArrays.h @@ -8,19 +8,15 @@ #include namespace Detail { - // NOLINTNEXTLINE(readability-identifier-naming) class glNamed; template concept IsglNamed = sizeof(Named) == sizeof(GLuint) && std::is_base_of_v; } -template -// NOLINTNEXTLINE(readability-identifier-naming) -struct glManagedArray; +template struct glManagedArray; namespace Detail { - // NOLINTNEXTLINE(readability-identifier-naming) class glNamed { public: glNamed() = default; @@ -45,7 +41,6 @@ namespace Detail { }; } -// NOLINTNEXTLINE(readability-identifier-naming) template struct glManagedSingle : public Named { glManagedSingle() noexcept { @@ -77,9 +72,7 @@ template struct glManagedSingle : p } }; -template -// NOLINTNEXTLINE(readability-identifier-naming) -struct glManagedArray : public std::array { +template struct glManagedArray : public std::array { using Arr = std::array; glManagedArray() noexcept @@ -118,10 +111,8 @@ struct glManagedArray : public std::array { } }; -// NOLINTBEGIN(readability-identifier-naming) template using glFrameBuffers = glManagedArray; using glFrameBuffer = glManagedSingle; template using glRenderBuffers = glManagedArray; using glRenderBuffer = glManagedSingle; -// NOLINTEND(readability-identifier-naming) -- cgit v1.3