Throw and transport ICE exceptions when things aren't found

1 files changed, 21 insertions, 7 deletions

diff --git a/gentoobrowse-api/unittests/testPortage.cpp b/gentoobrowse-api/unittests/testPortage.cpp
index 14fe16b..9cdbd1f 100644
--- a/gentoobrowse-api/unittests/testPortage.cpp
+++ b/gentoobrowse-api/unittests/testPortage.cpp
@@ -9,7 +9,7 @@ BOOST_FIXTURE_TEST_SUITE(tp, TestClient)
 
 BOOST_AUTO_TEST_CASE( getCategoryMissing )
 {
-	BOOST_REQUIRE_THROW(p->getCategory(0), std::exception);
+	BOOST_REQUIRE_THROW(p->getCategory(0), Slicer::NoRowsReturned);
 }
 
 BOOST_AUTO_TEST_CASE( getCategory )
@@ -22,6 +22,11 @@ BOOST_AUTO_TEST_CASE( getCategory )
 	BOOST_REQUIRE_EQUAL(169, cat->summary->length());
 }
 
+BOOST_AUTO_TEST_CASE( findCategoryMissing )
+{
+	BOOST_REQUIRE_THROW(p->findCategory("missing"), Slicer::NoRowsReturned);
+}
+
 BOOST_AUTO_TEST_CASE( findCategory )
 {
 	auto cat = p->findCategory("app-backup");
@@ -103,7 +108,7 @@ BOOST_AUTO_TEST_CASE( getOverviewCategoriesInSuper )
 
 BOOST_AUTO_TEST_CASE( getPackageMissing )
 {
-	BOOST_REQUIRE_THROW(p->getPackage(0), std::exception);
+	BOOST_REQUIRE_THROW(p->getPackage(0), Slicer::NoRowsReturned);
 }
 
 BOOST_AUTO_TEST_CASE( getPackage )
@@ -120,17 +125,16 @@ BOOST_AUTO_TEST_CASE( getPackage )
 	BOOST_REQUIRE_EQUAL("Default assignee for orphaned packages", pkg->maintainername);
 }
 
-BOOST_AUTO_TEST_CASE( findPackage )
+BOOST_AUTO_TEST_CASE( findPackageMissing )
 {
-	auto cat = p->findPackage("not", "here");
-	BOOST_REQUIRE(!cat);
+	BOOST_REQUIRE_THROW(p->findPackage("not", "here"), Slicer::NoRowsReturned);
 }
 
-BOOST_AUTO_TEST_CASE( findPackageMissing )
+BOOST_AUTO_TEST_CASE( findPackage )
 {
 	auto pkg = p->findPackage("dev-vcs", "archway");
 	BOOST_REQUIRE(pkg);
-	BOOST_REQUIRE_EQUAL(53258, (*pkg)->packageid);
+	BOOST_REQUIRE_EQUAL(53258, pkg->packageid);
 }
 
 BOOST_AUTO_TEST_CASE( getAllPackages )
@@ -232,6 +236,11 @@ BOOST_AUTO_TEST_CASE( getRecentAdditions )
 	BOOST_REQUIRE_EQUAL("GPL-2", es.front()->license);
 }
 
+BOOST_AUTO_TEST_CASE( getBugMissing )
+{
+	BOOST_REQUIRE_THROW(p->getBug(10), Slicer::NoRowsReturned);
+}
+
 BOOST_AUTO_TEST_CASE( getBug )
 {
 	auto b = p->getBug(567064);
@@ -262,6 +271,11 @@ BOOST_AUTO_TEST_CASE( getBugsSearch )
 	BOOST_REQUIRE_EQUAL(567682, bs[2]->bugid);
 }
 
+BOOST_AUTO_TEST_CASE( getNewsItemMissing )
+{
+	BOOST_REQUIRE_THROW(p->getNewsItem("2015-02-02-use-libav"), Slicer::NoRowsReturned);
+}
+
 BOOST_AUTO_TEST_CASE( getNewsItem )
 {
 	auto n = p->getNewsItem("2015-02-01-use-libav");