From bf8c4b6990a203c28b92ca09e170d0cbea206092 Mon Sep 17 00:00:00 2001 From: randomdan Date: Thu, 25 Nov 2010 19:26:04 +0000 Subject: Use proper ODBC SQL_SUCCEEDED macro, not SQL_SUCCESS comparison --- libodbcpp/modifycommand.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'libodbcpp/modifycommand.cpp') diff --git a/libodbcpp/modifycommand.cpp b/libodbcpp/modifycommand.cpp index 45022b0..84979e2 100644 --- a/libodbcpp/modifycommand.cpp +++ b/libodbcpp/modifycommand.cpp @@ -17,18 +17,16 @@ ODBC::ModifyCommand::execute(bool anc) throw Error("Transaction has been aborted, not issuing any more commands"); } RETCODE rc = SQLExecute(hStmt); - if (rc != SQL_SUCCESS) { - if (rc == SQL_SUCCESS_WITH_INFO) { - // Log info - } - else if (rc != SQL_NO_DATA || !anc) { + if (!SQL_SUCCEEDED(rc)) { + if (rc != SQL_NO_DATA || !anc) { connection.abortTx(); throw Error(rc, SQL_HANDLE_STMT, hStmt, "%s: SQLExecute", __FUNCTION__); } } SQLINTEGER rows; - if ((rc = SQLRowCount(hStmt, &rows)) != SQL_SUCCESS) { + rc = SQLRowCount(hStmt, &rows); + if (!SQL_SUCCEEDED(rc)) { connection.abortTx(); throw Error(rc, SQL_HANDLE_STMT, hStmt, "%s: SQLRowCount", __FUNCTION__); -- cgit v1.2.3