From ed02d2c0e41472e865f2075ab617d579383c356a Mon Sep 17 00:00:00 2001 From: Benoit Foucher Date: Thu, 29 Nov 2012 18:32:58 +0100 Subject: Fixed ICE-5050 - Except.py issue on Windows where process couldn't be terminated --- scripts/Expect.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'scripts/Expect.py') diff --git a/scripts/Expect.py b/scripts/Expect.py index 2515d57edc1..f7eafd8cc95 100755 --- a/scripts/Expect.py +++ b/scripts/Expect.py @@ -335,11 +335,12 @@ class Expect (object): # # universal_newlines = True is necessary for Python 3 on Windows # - # We set shell=True to make sure executables are correctly searched - # in directories specified by the PATH environment variable. + # We can't use shell=True because terminate() wouldn't + # work. This means the PATH isn't searched for the + # command. # CREATE_NEW_PROCESS_GROUP = 512 - self.p = subprocess.Popen(command, env = env, cwd = cwd, shell=True, bufsize=0, stdin=subprocess.PIPE, + self.p = subprocess.Popen(command, env = env, cwd = cwd, shell=False, bufsize=0, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, creationflags = CREATE_NEW_PROCESS_GROUP, universal_newlines=True) else: -- cgit v1.2.3