From 3a55ebb51b8914b60d308a0535d9abf97567138d Mon Sep 17 00:00:00 2001 From: Benoit Foucher Date: Thu, 12 Oct 2017 17:10:39 +0200 Subject: Fixed generated code warnings showing up with Objective-C and Xcode 9.0 (ICE-8540) --- cpp/src/slice2objc/Gen.cpp | 4 ++-- cpp/src/slice2objc/ObjCUtil.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'cpp/src/slice2objc') diff --git a/cpp/src/slice2objc/Gen.cpp b/cpp/src/slice2objc/Gen.cpp index c2ff2e2bca9..1c4b7e58943 100644 --- a/cpp/src/slice2objc/Gen.cpp +++ b/cpp/src/slice2objc/Gen.cpp @@ -449,7 +449,7 @@ Slice::ObjCVisitor::getParams(const OperationPtr& op, bool internal) const string typeString; if((*q)->isOutParam()) { - typeString = outTypeToString(type, (*q)->optional(), false, true); + typeString = outTypeToString(type, (*q)->optional(), true, true); } else { @@ -524,7 +524,7 @@ Slice::ObjCVisitor::getUnmarshalParams(const OperationPtr& op, bool internal) co { result += " " + getParamId(*q); } - result += ":(" + outTypeToString(type, (*q)->optional(), false, true) + ")" + getParamName(*q, internal); + result += ":(" + outTypeToString(type, (*q)->optional(), true, true) + ")" + getParamName(*q, internal); } } return result; diff --git a/cpp/src/slice2objc/ObjCUtil.cpp b/cpp/src/slice2objc/ObjCUtil.cpp index 253519c837a..d5bf0e6d9c3 100644 --- a/cpp/src/slice2objc/ObjCUtil.cpp +++ b/cpp/src/slice2objc/ObjCUtil.cpp @@ -406,7 +406,7 @@ Slice::ObjCGenerator::outTypeToString(const TypePtr& type, bool optional, bool a s += "*"; } } - if(autoreleasing && !isValueType(type)) + if(autoreleasing && (!isValueType(type) || optional)) { s += " ICE_AUTORELEASING_QUALIFIER"; } -- cgit v1.2.3