adding comments warning about changes to proxyToString operations breaking

    features

7 files changed, 42 insertions, 1 deletions

diff --git a/java/src/IceInternal/DirectReference.java b/java/src/IceInternal/DirectReference.java
index f36eb64ab3c..c8a2961adaf 100644
--- a/java/src/IceInternal/DirectReference.java
+++ b/java/src/IceInternal/DirectReference.java
@@ -146,6 +146,13 @@ public class DirectReference extends RoutableReference
     public String
     toString()
     {
+	//
+	// WARNING: Certain features, such as proxy validation in Glacier2,
+	// depend on the format of proxy strings. Changes to toString() and
+	// methods called to generate parts of the reference string could break
+	// these features. Please review for all features that depend on the
+	// format of proxyToString() before changing this and related code.
+	//
 	StringBuffer s = new StringBuffer();
 	s.append(super.toString());
 
diff --git a/java/src/IceInternal/IndirectReference.java b/java/src/IceInternal/IndirectReference.java
index 3564985d8a6..edd52236b18 100644
--- a/java/src/IceInternal/IndirectReference.java
+++ b/java/src/IceInternal/IndirectReference.java
@@ -157,6 +157,13 @@ public class IndirectReference extends RoutableReference
     public String
     toString()
     {
+	//
+	// WARNING: Certain features, such as proxy validation in Glacier2,
+	// depend on the format of proxy strings. Changes to toString() and
+	// methods called to generate parts of the reference string could break
+	// these features. Please review for all features that depend on the
+	// format of proxyToString() before changing this and related code.
+	//
         String result = super.toString();
 
 	if(_adapterId.length() == 0)
diff --git a/java/src/IceInternal/PropertyNames.java b/java/src/IceInternal/PropertyNames.java
index 023989584a9..2d111c9383d 100644
--- a/java/src/IceInternal/PropertyNames.java
+++ b/java/src/IceInternal/PropertyNames.java
@@ -8,7 +8,6 @@
 // **********************************************************************
 
 // Generated by makeprops.py from file `../config/PropertyNames.def', Mon Apr 17 10:30:14 2006
-
 // IMPORTANT: Do not edit this file -- any edits made here will be lost!
 
 package IceInternal;
diff --git a/java/src/IceInternal/Reference.java b/java/src/IceInternal/Reference.java
index 9e75e74f528..8fa583f540e 100644
--- a/java/src/IceInternal/Reference.java
+++ b/java/src/IceInternal/Reference.java
@@ -230,6 +230,13 @@ public abstract class Reference implements Cloneable
     public String
     toString()
     {
+	//
+	// WARNING: Certain features, such as proxy validation in Glacier2,
+	// depend on the format of proxy strings. Changes to toString() and
+	// methods called to generate parts of the reference string could break
+	// these features. Please review for all features that depend on the
+	// format of proxyToString() before changing this and related code.
+	//
         StringBuffer s = new StringBuffer();
 
         //
diff --git a/java/src/IceInternal/TcpEndpointI.java b/java/src/IceInternal/TcpEndpointI.java
index 6f1ba40af8c..ccaf60b3c14 100644
--- a/java/src/IceInternal/TcpEndpointI.java
+++ b/java/src/IceInternal/TcpEndpointI.java
@@ -184,6 +184,13 @@ final class TcpEndpointI extends EndpointI
     public String
     _toString()
     {
+	//
+	// WARNING: Certain features, such as proxy validation in Glacier2,
+	// depend on the format of proxy strings. Changes to toString() and
+	// methods called to generate parts of the reference string could break
+	// these features. Please review for all features that depend on the
+	// format of proxyToString() before changing this and related code.
+	//
         String s = "tcp -h " + _host + " -p " + _port;
         if(_timeout != -1)
         {
diff --git a/java/src/IceInternal/UdpEndpointI.java b/java/src/IceInternal/UdpEndpointI.java
index 02937364252..e5842683ad5 100644
--- a/java/src/IceInternal/UdpEndpointI.java
+++ b/java/src/IceInternal/UdpEndpointI.java
@@ -309,6 +309,13 @@ final class UdpEndpointI extends EndpointI
     public String
     _toString()
     {
+	//
+	// WARNING: Certain features, such as proxy validation in Glacier2,
+	// depend on the format of proxy strings. Changes to toString() and
+	// methods called to generate parts of the reference string could break
+	// these features. Please review for all features that depend on the
+	// format of proxyToString() before changing this and related code.
+	//
         String s = "udp";
 
 	if((int)_protocolMajor != 1 || (int)_protocolMinor != 0)
diff --git a/java/src/IceSSL/EndpointI.java b/java/src/IceSSL/EndpointI.java
index dad60b5b89d..debeb4482ff 100644
--- a/java/src/IceSSL/EndpointI.java
+++ b/java/src/IceSSL/EndpointI.java
@@ -184,6 +184,13 @@ final class EndpointI extends IceInternal.EndpointI
     public String
     _toString()
     {
+	//
+	// WARNING: Certain features, such as proxy validation in Glacier2,
+	// depend on the format of proxy strings. Changes to toString() and
+	// methods called to generate parts of the reference string could break
+	// these features. Please review for all features that depend on the
+	// format of proxyToString() before changing this and related code.
+	//
 	String s = "ssl -h " + _host + " -p " + _port;
 	if(_timeout != -1)
 	{