diff options
| author | Marc Laukien <marc@zeroc.com> | 2002-06-25 13:52:21 +0000 |
|---|---|---|
| committer | Marc Laukien <marc@zeroc.com> | 2002-06-25 13:52:21 +0000 |
| commit | 408fa2a443be8b992f2fca3b0d3310d86a60e5bd (patch) | |
| tree | d1a24c4b77eb20c93be5eef12de9fe9a2bc69a2b /cpp/src/Slice/Parser.cpp | |
| parent | Win32, style fixes (diff) | |
| download | ice-408fa2a443be8b992f2fca3b0d3310d86a60e5bd.tar.bz2 ice-408fa2a443be8b992f2fca3b0d3310d86a60e5bd.tar.xz ice-408fa2a443be8b992f2fca3b0d3310d86a60e5bd.zip | |
comments
Diffstat (limited to 'cpp/src/Slice/Parser.cpp')
| -rw-r--r-- | cpp/src/Slice/Parser.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/cpp/src/Slice/Parser.cpp b/cpp/src/Slice/Parser.cpp index 27ef9d832e6..32b79a55f0b 100644 --- a/cpp/src/Slice/Parser.cpp +++ b/cpp/src/Slice/Parser.cpp @@ -338,6 +338,9 @@ Slice::Container::createClassDef(const string& name, bool intf, const ClassList& return def; } +// TODO: ML: The order of declaration in the header should match the +// order of definition in the .cpp file. + // // Return true if the class definition cdp is on one of the class lists in gpl, false otherwise. // @@ -346,7 +349,9 @@ Slice::Container::isInList(const GraphPartitionList& gpl, const ClassDefPtr cdp) { for(GraphPartitionList::const_iterator i = gpl.begin(); i != gpl.end(); ++i) { + // TODO: ML: Why not just i->begin()? (Here and elsewhere.) if(find((*i).begin(), (*i).end(), cdp) != (*i).end()) +// TODO: ML: Indentation. { return true; } @@ -354,6 +359,7 @@ Slice::Container::isInList(const GraphPartitionList& gpl, const ClassDefPtr cdp) return false; } +// TODO: ML: Line length must be <= 119 chars. void Slice::Container::addPartition(GraphPartitionList& gpl, GraphPartitionList::reverse_iterator tail, const ClassDefPtr base) const { |